Skip to content

Fix rabbitmqserver Golden Container 2.0 #11287

Merged
rikenm1 merged 1 commit intomainfrom
rmaharjan/fix-rbgc2.0
Dec 3, 2024
Merged

Fix rabbitmqserver Golden Container 2.0 #11287
rikenm1 merged 1 commit intomainfrom
rmaharjan/fix-rbgc2.0

Conversation

@rikenm1
Copy link
Copy Markdown
Contributor

@rikenm1 rikenm1 commented Dec 2, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Fix the broken rabbitmq-server golden container.

Change Log
  • Change: The rabbitmq-server version was hardcoded.
Does this affect the toolchain?

YES/NO
NO

Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Dec 2, 2024
@rikenm1 rikenm1 marked this pull request as ready for review December 2, 2024 23:13
@rikenm1 rikenm1 requested a review from a team as a code owner December 2, 2024 23:13
Copy link
Copy Markdown
Contributor

@sameluch sameluch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks a lot like our other PR just for reference: #9256

@rikenm1 rikenm1 merged commit bb838f4 into main Dec 3, 2024
@rikenm1 rikenm1 deleted the rmaharjan/fix-rbgc2.0 branch December 3, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants