Skip to content

Added package rubygem-racc to SPECS-EXTENDED#11355

Open
SumitJenaHCL wants to merge 4 commits intomicrosoft:3.0-devfrom
SumitJenaHCL:topic_rubygem-racc
Open

Added package rubygem-racc to SPECS-EXTENDED#11355
SumitJenaHCL wants to merge 4 commits intomicrosoft:3.0-devfrom
SumitJenaHCL:topic_rubygem-racc

Conversation

@SumitJenaHCL
Copy link
Copy Markdown
Contributor

@SumitJenaHCL SumitJenaHCL commented Dec 8, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
This PR is to add package rubygem-racc to SPECS-EXTENDED

Change Log
  • SPECS-EXTENDED/rubygem-racc/racc-create-tarball-missing-files.sh
  • SPECS-EXTENDED/rubygem-racc/rubygem-racc.signatures.json
  • SPECS-EXTENDED/rubygem-racc/rubygem-racc.spec
  • cgmanifest.json
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Local Build

@SumitJenaHCL SumitJenaHCL requested review from a team as code owners December 8, 2024 21:24
@SumitJenaHCL
Copy link
Copy Markdown
Contributor Author

This PR is raised to successfully merge #11360

@SumitJenaHCL SumitJenaHCL marked this pull request as draft January 2, 2025 10:48
@SumitJenaHCL SumitJenaHCL reopened this Feb 21, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Feb 21, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added documentation Improvements or additions to documentation Tools Schema Changes to image configurations labels Feb 24, 2025
@SumitJenaHCL SumitJenaHCL marked this pull request as ready for review February 24, 2025 08:42
{
"Signatures": {
"racc-1.8.1.gem": "4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f",
"racc-create-tarball-missing-files.sh": "5102ab34a97c558151994bed4983e57c50ea5ef9e7acab214dd444edca0c000b",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is local only, do we need signature for this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find a way to fetch the tarball with the latest commit. So, resorted to just add the script as the source to generate the tarball. Could it be possible to run it during setting up the pipeline.

NAME=racc
VERSION=$1

git clone https://github.com/ruby/racc.git
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of git cloning as pipeline/build system may not have access to external internet transaction (also security), could you please check alternative to keep missing files downloaded to blob storage?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script is to fetch the latest changes from the upstream. Can't find a way to fetch the tarball with the latest commit. So, resorted to just add the script as the source to generate the tarball. Could it be possible to run it during setting up the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 documentation Improvements or additions to documentation Packaging Schema Changes to image configurations specs-extended PR to fix SPECS-EXTENDED Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants