Skip to content

Added package rubygem-test-unit-ruby-core to SPECS-EXTENDED#11357

Open
SumitJenaHCL wants to merge 1 commit intomicrosoft:3.0-devfrom
SumitJenaHCL:topic_rubygem-test-unit-ruby-core
Open

Added package rubygem-test-unit-ruby-core to SPECS-EXTENDED#11357
SumitJenaHCL wants to merge 1 commit intomicrosoft:3.0-devfrom
SumitJenaHCL:topic_rubygem-test-unit-ruby-core

Conversation

@SumitJenaHCL
Copy link
Copy Markdown
Contributor

@SumitJenaHCL SumitJenaHCL commented Dec 8, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
This PR is to add package rubygem-test-unit-ruby-core to SPECS-EXTENDED

Change Log
  • SPECS-EXTENDED/rubygem-test-unit-ruby-core/rubygem-test-unit-ruby-core.signatures.json
  • SPECS-EXTENDED/rubygem-test-unit-ruby-core/rubygem-test-unit-ruby-core.spec
  • SPECS-EXTENDED/rubygem-test-unit-ruby-core/test-unit-ruby-core-create-missing-files.sh
  • cgmanifest.json
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Local Build

@SumitJenaHCL SumitJenaHCL requested review from a team as code owners December 8, 2024 21:31
@SumitJenaHCL
Copy link
Copy Markdown
Contributor Author

This PR is raised to successfully merge #11360

@SumitJenaHCL SumitJenaHCL marked this pull request as draft January 2, 2025 10:48
@SumitJenaHCL SumitJenaHCL marked this pull request as ready for review January 2, 2025 13:29
TMPDIRPATH=$(mktemp -d /var/tmp/${REPONAME}-tar-XXXXXX)
pushd $TMPDIRPATH

git clone ${REPOURL}/${REPONAME}.git
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if these can be done locally because external downloading a Git repo during build process may not be a good thing. Keep things either locally or we can upload to local storage.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find a way to fetch the tarball with the latest commit. So, resorted to just add the script as the source to generate the tarball. Could it be possible to run it during setting up the pipeline.

@SumitJenaHCL SumitJenaHCL requested a review from kgodara912 April 18, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants