Skip to content

Added logging for missed pre-cacher download error.#11897

Merged
PawelWMS merged 1 commit intomainfrom
pawelwi/extend_precacher_logging_2.0
Jan 28, 2025
Merged

Added logging for missed pre-cacher download error.#11897
PawelWMS merged 1 commit intomainfrom
pawelwi/extend_precacher_logging_2.0

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Cherry-pick of #11895

Added logging for one err variable we never printed.

Does this affect the toolchain?

No.

Test Methodology
  • PR check Go tests.

@PawelWMS PawelWMS requested a review from a team as a code owner January 14, 2025 00:36
@microsoft-github-policy-service microsoft-github-policy-service Bot added Tools main PR Destined for main labels Jan 14, 2025
@PawelWMS PawelWMS merged commit d412473 into main Jan 28, 2025
@PawelWMS PawelWMS deleted the pawelwi/extend_precacher_logging_2.0 branch January 28, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants