cdi: Renaming binaries in the SPEC file to align with upstream naming conventions#12214
Merged
sharath-srikanth-chellappa merged 1 commit into3.0-devfrom Feb 5, 2025
Conversation
e69cb40 to
d9c9895
Compare
Contributor
|
LGTM |
Contributor
mandeepsplaha
left a comment
There was a problem hiding this comment.
The changes look good. Can you please run a container build for the cdi components and ensure they build successfully, and can you also link the build run in the PR description?
Contributor
Author
Added that information to the PR description. Also added a manual trivy scan of the container images |
romoh
approved these changes
Feb 5, 2025
SumitJenaHCL
pushed a commit
to SumitJenaHCL/azurelinux
that referenced
this pull request
Feb 24, 2025
… conventions (microsoft#12214) Co-authored-by: Sharath Srikanth Chellappa <sharathsr@microsoft.com>
binujp
pushed a commit
that referenced
this pull request
Feb 26, 2025
… conventions (#12214) Co-authored-by: Sharath Srikanth Chellappa <sharathsr@microsoft.com>
KavyaSree2610
pushed a commit
to KavyaSree2610/azurelinux
that referenced
this pull request
Mar 24, 2025
… conventions (microsoft#12214) Co-authored-by: Sharath Srikanth Chellappa <sharathsr@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cdi binaries are misnamed in the SPEC file leading to additional Dockerfile commands to rename the binaries. Changing the SPEC file naming conventions to align with upstream and removing Dockerfile workarounds.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
The cdi binaries are misnamed in the SPEC file leading to additional Dockerfile commands to rename the binaries. Changing the SPEC file naming conventions to align with upstream and removing Dockerfile workarounds.
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology