Skip to content

Print errors when creating directories in makefile#12338

Merged
dmcilvaney merged 2 commits intomicrosoft:mainfrom
dmcilvaney:damcilva/2.0/tools/print_folder_create
Feb 19, 2025
Merged

Print errors when creating directories in makefile#12338
dmcilvaney merged 2 commits intomicrosoft:mainfrom
dmcilvaney:damcilva/2.0/tools/print_folder_create

Conversation

@dmcilvaney
Copy link
Copy Markdown
Contributor

@dmcilvaney dmcilvaney commented Feb 12, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

2.0 backport of #12335

Change Log
  • Update the Makefile's create_folder function to print stderr if any is generated by mkdir.
Does this affect the toolchain?

NO

Associated issues
Test Methodology

@dmcilvaney dmcilvaney requested a review from a team as a code owner February 12, 2025 21:18
@microsoft-github-policy-service microsoft-github-policy-service Bot added Tools main PR Destined for main labels Feb 12, 2025
@dmcilvaney dmcilvaney changed the title Print errors when making directories in makefile Print errors when creating directories in makefile Feb 12, 2025
Comment thread toolkit/scripts/utils.mk Outdated
@dmcilvaney dmcilvaney merged commit 8979ebc into microsoft:main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants