Package Test Fix for python-toolz #13324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Packaging
3.0-dev
rikenm1
reviewed
Apr 9, 2025
| %check | ||
| pip3 install nose | ||
| nosetests | ||
| # skip test_shakespeare due to missing directory/files in source tar (Fedora also skips this test for a similar reason) |
Contributor
There was a problem hiding this comment.
I think it is a good idea to credit Fedora in the changelog if you inherited the patch or any idea from Fedora.
Contributor
Author
There was a problem hiding this comment.
Sure I will tag accordingly
rikenm1
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
python-toolz was using nose tests previously which are no longer compatible with python3.12. Instead we will use pytest to run as instructed upstream. Additionally, upgrading to version 0.12.1 for official python3.12 support instead of just 3.11.
Change Log
Does this affect the toolchain?
NO
Test Methodology
sudo make build-packages REBUILD_TOOLS=y REBUILD_TOOLCHAIN=n DAILY_BUILD_ID=lkg SRPM_PACK_LIST=python-toolz PACKAGE_REBUILD_LIST=python-toolz RUN_CHECK=y -j100