Skip to content

Conversation

@kevin-b-lockwood
Copy link
Contributor

@kevin-b-lockwood kevin-b-lockwood commented Apr 16, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch cert-manager for CVE-2025-32386, CVE-2025-32387, and CVE-2025-22872

Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Local build

@kevin-b-lockwood kevin-b-lockwood requested a review from a team as a code owner April 16, 2025 22:11
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Apr 16, 2025
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly bump up release, also CVE-2025-32387 patches file are not available

@kevin-b-lockwood kevin-b-lockwood marked this pull request as draft April 22, 2025 22:08
@kevin-b-lockwood
Copy link
Contributor Author

Kindly bump up release, also CVE-2025-32387 patches file are not available

Ok, I fixed it up. To clarify, CVE-2025-32386 and CVE-2025-32387 are fixed by the same patch according to upstream

@kevin-b-lockwood kevin-b-lockwood marked this pull request as ready for review April 22, 2025 23:59
@kevin-b-lockwood kevin-b-lockwood changed the title [Medium] Patch cert-manager for CVE-2025-32386, CVE-2025-32387 [Medium] Patch cert-manager for CVE-2025-32386, CVE-2025-32387, CVE-2025-22872 Apr 24, 2025
@kevin-b-lockwood
Copy link
Contributor Author

Updated to add a CVE that was just assigned to me

Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified the upstream patch for CVE-2025-22872, Kindly create a new patch with your credentials and put the upstream reference in the patch

Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have changed the file names in the CVE-2025-32386 patch and modified it, it would be better to create a patch and mention the upstream patch link in the patch. Also, please refrain from adding everything to the SPEC file.

@Kanishk-Bansal
Copy link
Contributor

Buddy Build

@kevin-b-lockwood
Copy link
Contributor Author

Also, please refrain from adding everything to the SPEC file.

My apologies, it's something I saw on the qemu spec file and I thought I was meant to be doing it like that. Future PRs will not have this.

@0xba1a 0xba1a merged commit d36a99b into microsoft:3.0-dev Jun 3, 2025
15 checks passed
AkarshHCL pushed a commit to AkarshHCL/azurelinux that referenced this pull request Jul 31, 2025
SumitJenaHCL pushed a commit to SumitJenaHCL/azurelinux that referenced this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants