Skip to content

git: use openssh-clients instead of full openssh package#13448

Merged
0xba1a merged 1 commit into3.0-devfrom
mfrw/git-remove-openssh-server
May 6, 2025
Merged

git: use openssh-clients instead of full openssh package#13448
0xba1a merged 1 commit into3.0-devfrom
mfrw/git-remove-openssh-server

Conversation

@mfrw
Copy link
Copy Markdown
Member

@mfrw mfrw commented Apr 17, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Decouple openssh-server and git. Only take a dependency on openssh-clients

Change Log
  • Updatre Requires as openssh-clients instead of openssh which bundles in openssh-server
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
  • NA
Test Methodology

@mfrw mfrw requested a review from a team as a code owner April 17, 2025 02:44
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Apr 17, 2025
@mfrw mfrw force-pushed the mfrw/git-remove-openssh-server branch from b6afbb4 to 51135c0 Compare April 21, 2025 10:22
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@mfrw mfrw force-pushed the mfrw/git-remove-openssh-server branch from 51135c0 to 65d60bd Compare April 25, 2025 05:45
Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream fedora spec also has same openssh-clients dependency only for git. LGTM.

@reubeno
Copy link
Copy Markdown
Member

reubeno commented May 5, 2025

@mfrw -- this is a righteous change, for sure, but could it be considered a breaking change from the 3.0 LTS's perspective? Is there a risk of an image builder that was unintentionally relying on openssh-server being included and will now no longer have it in their image?

@mfrw
Copy link
Copy Markdown
Member Author

mfrw commented May 6, 2025

@mfrw -- this is a righteous change, for sure, but could it be considered a breaking change from the 3.0 LTS's perspective? Is there a risk of an image builder that was unintentionally relying on openssh-server being included and will now no longer have it in their image?

let me verify this

@0xba1a 0xba1a merged commit 97d5876 into 3.0-dev May 6, 2025
16 checks passed
@0xba1a 0xba1a deleted the mfrw/git-remove-openssh-server branch May 6, 2025 13:18
AkarshHCL pushed a commit to AkarshHCL/azurelinux that referenced this pull request Jul 31, 2025
…3448)

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
SumitJenaHCL pushed a commit to SumitJenaHCL/azurelinux that referenced this pull request Aug 20, 2025
…3448)

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants