Skip to content

generic-logos: fix the build error#13573

Merged
0xba1a merged 4 commits intomicrosoft:3.0-devfrom
durgajagadeesh:Topic_generic-logos
May 6, 2025
Merged

generic-logos: fix the build error#13573
0xba1a merged 4 commits intomicrosoft:3.0-devfrom
durgajagadeesh:Topic_generic-logos

Conversation

@durgajagadeesh
Copy link
Copy Markdown
Contributor

@durgajagadeesh durgajagadeesh commented Apr 24, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary
  • generic-logos: fix the build error
Change Log
  • Build error fix
  • License verified
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@durgajagadeesh durgajagadeesh requested a review from a team as a code owner April 24, 2025 07:04
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Apr 24, 2025
kgodara912
kgodara912 reviewed Apr 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for next stage: buddy build pipeline.

@durgajagadeesh
Copy link
Copy Markdown
Contributor Author

durgajagadeesh commented Apr 28, 2025

Good for next stage: buddy build pipeline.

Hi @kgodara912,
The buddy build pipeline results successful.
image

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=795440&view=results

Thank you!

kgodara912
kgodara912 approved these changes Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package compiles and installs fine. LGTM.

Comment thread SPECS-EXTENDED/generic-logos/generic-logos.spec
License: GPLv2 and LGPLv2+
BuildArch: noarch

Obsoletes: redhat-logos
Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this doesn't cause compilation error I think, only the top two lines are causing. Because this package provides the same redhat-logos below, so it is fine to obsolete older ones.

Copy link
Copy Markdown
Contributor Author

@durgajagadeesh durgajagadeesh May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kgodara912,
I’ve updated the redhat-logos to the older version, as per your suggestion.
Thank you!

0xba1a
0xba1a reviewed Apr 30, 2025
View reviewed changes
Comment thread SPECS-EXTENDED/generic-logos/generic-logos.spec Outdated

%changelog
* Thu Apr 24 2025 Durga Jagadeesh Palli <v-dpalli@microsoft.com> - 18.0.0-12
- Fix the build error.
Copy link
Copy Markdown
Member

@0xba1a 0xba1a Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please elaborate how the build errors are fixed

Copy link
Copy Markdown
Contributor Author

@durgajagadeesh durgajagadeesh May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @0xba1a,
I have update the same as suggested.
Please let me know if anything else has to be update from my side.
Thank you!

@durgajagadeesh durgajagadeesh force-pushed the Topic_generic-logos branch from eb739e8 to 177d00b Compare May 2, 2025 13:40
@durgajagadeesh durgajagadeesh force-pushed the Topic_generic-logos branch from 177d00b to 6277194 Compare May 2, 2025 13:41
@0xba1a 0xba1a merged commit 63c72aa into microsoft:3.0-dev May 6, 2025
15 checks passed
AkarshHCL pushed a commit to AkarshHCL/azurelinux that referenced this pull request Jul 31, 2025
@durgajagadeesh @AkarshHCL
generic-logos: fix the build error (microsoft#13573)
5f0d633
SumitJenaHCL pushed a commit to SumitJenaHCL/azurelinux that referenced this pull request Aug 20, 2025
@durgajagadeesh @SumitJenaHCL
generic-logos: fix the build error (microsoft#13573)
f79944a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xba1a 0xba1a 0xba1a approved these changes

@kgodara912 kgodara912 kgodara912 approved these changes

Assignees

No one assigned

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@durgajagadeesh @0xba1a @kgodara912