Skip to content

[AUTO-CHERRYPICK] SymCrypt-OpenSSL -- Update mechanism for creating keysinuse logging directory. - branch 3.0-dev #13739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jslobodzian merged 1 commit into from
May 13, 2025
Merged

[AUTO-CHERRYPICK] SymCrypt-OpenSSL -- Update mechanism for creating keysinuse logging directory. - branch 3.0-dev #13739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions SPECS/SymCrypt-OpenSSL/SymCrypt-OpenSSL.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Summary: The SymCrypt engine for OpenSSL (SCOSSL) allows the use of OpenSSL with SymCrypt as the provider for core cryptographic operations
Name: SymCrypt-OpenSSL
Version: 1.8.0
Release: 1%{?dist}
Release: 2%{?dist}
License: MIT
Vendor: Microsoft Corporation
Distribution: Azure Linux
Expand Down Expand Up @@ -49,6 +49,7 @@ mkdir -p %{buildroot}%{_libdir}/engines-3/
mkdir -p %{buildroot}%{_libdir}/ossl-modules/
mkdir -p %{buildroot}%{_includedir}
mkdir -p %{buildroot}%{_sysconfdir}/pki/tls/
mkdir -p %{buildroot}%{_localstatedir}/log/keysinuse/

# We still install the engine for backwards compatibility with legacy applications. Callers must
# explicitly load the engine to use it. It will be removed in a future release.
Expand All @@ -57,15 +58,6 @@ install bin/SymCryptProvider/symcryptprovider.so %{buildroot}%{_libdir}/ossl-mod
install SymCryptEngine/inc/e_scossl.h %{buildroot}%{_includedir}/e_scossl.h
install SymCryptProvider/symcrypt_prov.cnf %{buildroot}%{_sysconfdir}/pki/tls/symcrypt_prov.cnf

%post
mkdir -p -m 1733 /var/log/keysinuse

%preun
# Remove the logging directory on uninstall, leaving it there on upgrade.
if [ "${1}" = "0" ]; then
rm -rf /var/log/keysinuse
fi

%check
./bin/SslPlay/SslPlay

Expand All @@ -76,7 +68,21 @@ fi
%{_includedir}/e_scossl.h
%{_sysconfdir}/pki/tls/symcrypt_prov.cnf

# The log directory for certsinuse logging has permissions set to 1733.
# These permissions are a result of a security review to mitigate potential risks:
# - Group and others are denied read access to prevent user-level code from inferring
# details about other running applications and their certsinuse usage.
# - All users have write and execute permissions to create new log files and to
# check file attributes (e.g., to ensure a log file hasn't been tampered with or
# replaced by a symlink).
# - The sticky bit is set to prevent malicious users from deleting the log files
# and interfering with certsinuse alerting mechanisms.
%dir %attr(1733, root, root) %{_localstatedir}/log/keysinuse/

%changelog
* Thu May 08 2025 Tobias Brick <tobiasb@microsoft.com> - 1.8.0-2
- Update mechanism for creating keysinuse logging directory.

* Thu Mar 27 2025 Maxwell Moyer-McKee <mamckee@microsoft.com> - 1.8.0-1
- Upgrade to SymCrypt-OpenSSL 1.8.0 with PBKDF2 and minor bugfixes

Expand Down
Loading