Skip to content

fix: ptest and installation issues for perl-CPAN-Changes#13760

Merged
0xba1a merged 6 commits into3.0-devfrom
kanbansal/CPAN-installation-ptest-fix
May 21, 2025
Merged

fix: ptest and installation issues for perl-CPAN-Changes#13760
0xba1a merged 6 commits into3.0-devfrom
kanbansal/CPAN-installation-ptest-fix

Conversation

@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

@Kanishk-Bansal Kanishk-Bansal commented May 12, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

  • Address installation issues for perl-CPAN-Changes for work item
  • Fix ptest for perl-CPAN-Changes
  • Add perl-Type-Tiny to the Core Repo from Fedora
  • Port some perl packages to the Core Repo (perl-Class-Method-Modifiers, perl-Moo, perl-Role-Tiny) from extended
  • Fix LICENSE issue of perl-Moo
Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

Kanishk Bansal added 2 commits May 12, 2025 11:02
…CPAN-Changes

Signed-off-by: Kanishk Bansal <kanbansal@microsoft.com>
@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner May 12, 2025 18:22
@Kanishk-Bansal Kanishk-Bansal added the ptest package testing (%check section in spec) label May 12, 2025
@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner May 12, 2025 18:22
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels May 12, 2025
@Kanishk-Bansal Kanishk-Bansal force-pushed the kanbansal/CPAN-installation-ptest-fix branch from 9ff8b64 to 2d3bd51 Compare May 12, 2025 18:34
@Kanishk-Bansal Kanishk-Bansal force-pushed the kanbansal/CPAN-installation-ptest-fix branch 2 times, most recently from a0bf1e4 to c4422c1 Compare May 12, 2025 19:30
@Kanishk-Bansal Kanishk-Bansal force-pushed the kanbansal/CPAN-installation-ptest-fix branch from c4422c1 to 6b59f44 Compare May 12, 2025 20:07
Comment thread SPECS/perl-CPAN-Changes/perl-CPAN-Changes.spec Outdated
Comment thread cgmanifest.json Outdated
Comment thread cgmanifest.json
Comment thread SPECS/perl-Type-Tiny/perl-Type-Tiny.signatures.json Outdated
Signed-off-by: Kanishk Bansal <kanbansal@microsoft.com>
Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package builds, tests and installs fine. LGTM.

@Kanishk-Bansal
Copy link
Copy Markdown
Contributor Author

Full Build

Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to have a conflict

@kgodara912 kgodara912 requested a review from Copilot May 20, 2025 09:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses installation and ptest failures for perl-CPAN-Changes, imports perl-Type-Tiny into the Core repo, ports additional Perl modules to Core, and fixes the LICENSE metadata for perl-Moo.

  • Fix ptest and installation for perl-CPAN-Changes by bumping release and adding missing dependencies.
  • Import perl-Type-Tiny into Core with spec and signature files.
  • Promote perl-Moo to Core and update its release and license verification.
  • Update license mappings for the new Type-Tiny package.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cgmanifest.json Add new component entry for perl-Type-Tiny
SPECS/perl-Type-Tiny/perl-Type-Tiny.spec Initial import of Type-Tiny spec into Core
SPECS/perl-Type-Tiny/perl-Type-Tiny.signatures.json Add signature for Type-Tiny source tarball
SPECS/perl-Moo/perl-Moo.spec Bump release to 4 and verify license
SPECS/perl-CPAN-Changes/perl-CPAN-Changes.spec Bump release to 2, add BuildRequires/Requires, add %license, fix ptest
LICENSES-AND-NOTICES/SPECS/data/licenses.json Include perl-Type-Tiny in license list
LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md Adjust Fedora license mapping row

Comment thread SPECS/perl-CPAN-Changes/perl-CPAN-Changes.spec Outdated
Comment thread cgmanifest.json
Comment thread SPECS/perl-CPAN-Changes/perl-CPAN-Changes.spec
@Kanishk-Bansal Kanishk-Bansal force-pushed the kanbansal/CPAN-installation-ptest-fix branch from f4389c9 to ba06c8c Compare May 20, 2025 09:48
@0xba1a 0xba1a merged commit 1c3a77d into 3.0-dev May 21, 2025
17 checks passed
@0xba1a 0xba1a deleted the kanbansal/CPAN-installation-ptest-fix branch May 21, 2025 06:57
AkarshHCL pushed a commit to AkarshHCL/azurelinux that referenced this pull request Jul 31, 2025
…#13760)

Signed-off-by: Kanishk Bansal <kanbansal@microsoft.com>
Co-authored-by: Kanishk Bansal <kanbansal@microsoft.com>
SumitJenaHCL pushed a commit to SumitJenaHCL/azurelinux that referenced this pull request Aug 20, 2025
…#13760)

Signed-off-by: Kanishk Bansal <kanbansal@microsoft.com>
Co-authored-by: Kanishk Bansal <kanbansal@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ptest package testing (%check section in spec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants