Skip to content

Patch docker-buildx for CVE-2025-0495 [Medium]#13768

Merged
0xba1a merged 2 commits into3.0-devfrom
skarambelkar/buildx/3.0/CVE-2025-0495
May 20, 2025
Merged

Patch docker-buildx for CVE-2025-0495 [Medium]#13768
0xba1a merged 2 commits into3.0-devfrom
skarambelkar/buildx/3.0/CVE-2025-0495

Conversation

@sandeepkarambelkar
Copy link
Copy Markdown
Contributor

@sandeepkarambelkar sandeepkarambelkar commented May 13, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch docker-buildx for CVE-2025-0495 [Medium]

Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

@sandeepkarambelkar sandeepkarambelkar requested a review from a team as a code owner May 13, 2025 06:50
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels May 13, 2025
Copy link
Copy Markdown
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original Patch Contains 6 files & Astrolabe shows 4 files affected. Can you please explain why have you only patched 2 files?

Also in Patch Header a file util/tracing/trace.go is mentioned but the diff is not. Can you please re check the patch?

@sandeepkarambelkar
Copy link
Copy Markdown
Contributor Author

sandeepkarambelkar commented May 19, 2025

Original Patch Contains 6 files & Astrolabe shows 4 files affected. Can you please explain why have you only patched 2 files?

Also in Patch Header a file util/tracing/trace.go is mentioned but the diff is not. Can you please re check the patch?

Hello Kanishk,

  1. The CVE (https://nvd.nist.gov/vuln/detail/CVE-2025-0495 ) is related to "secure values may be inadvertently captured in OpenTelemetry traces as part of the arguments and flags for the traced CLI command"
  2. The patch applied handles the tracing to specifically trace required values and not the complete command object which is taken from upstream. These are the changes which address CVE
  3. You can see the commits of the related patch through PR - https://github.com/docker/buildx/pull/3068/commits which confirm the other changes are related to different feature localstate.
  4. We are running on lower version of docker-buildx and if we want to apply patch fully we need to upgrade which I felt not required when I went through the CVE and the upstream patch
  5. As an additional artifact to support my analysis, see patch mentioned in "Fixed by: " field done by debian in its distro. https://security-tracker.debian.org/tracker/[CVE-2025-0495](https://security-tracker.debian.org/tracker/CVE-2025-0495)

For your second point, read the patch file carefully, you will see the diff.

image

@0xba1a 0xba1a merged commit 91ef9b2 into 3.0-dev May 20, 2025
17 checks passed
@0xba1a 0xba1a deleted the skarambelkar/buildx/3.0/CVE-2025-0495 branch May 20, 2025 14:56
AkarshHCL pushed a commit to AkarshHCL/azurelinux that referenced this pull request Jul 31, 2025
SumitJenaHCL pushed a commit to SumitJenaHCL/azurelinux that referenced this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants