Conversation
There was a problem hiding this comment.
Package builds, tests and installs file. Full build is also fine. Except minor typo, LGTM.
For extended repo packages, if you build it next time in buddy build, please put the extended repo packages in extended specs section along with rust in specs section of buddy build because full build doesn't build extended repo. Though they may not cause issue for this change but good to test them to ensure that we don't cause any regression in extended repo.
Updated the buddy build link in which Extended Specs are also built with rust |
Co-authored-by: kavyasree <kkaitepalli@microsoft.com>
Co-authored-by: kavyasree <kkaitepalli@microsoft.com>
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology