Skip to content

[MEDIUM] Patch nodejs for CVE-2025-23165 CVE-2025-23166#13901

Merged
0xba1a merged 1 commit intomicrosoft:3.0-devfrom
aninda-al:v-anipradhan/nodejs/CVE-2025-23165-CVE-2025-23166
Jun 10, 2025
Merged

[MEDIUM] Patch nodejs for CVE-2025-23165 CVE-2025-23166#13901
0xba1a merged 1 commit intomicrosoft:3.0-devfrom
aninda-al:v-anipradhan/nodejs/CVE-2025-23165-CVE-2025-23166

Conversation

@aninda-al
Copy link
Copy Markdown
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Address CVE-2025-23165 CVE-2025-23166

CVE-2025-23166 Upstream Patch Reference: nodejs/node@6c57465
CVE-2025-23165 Upstream Patch Reference: nodejs/node@9e13bf0

Change Log
Does this affect the toolchain?

NO

Associated issues
  • NA
Links to CVEs
Test Methodology
  • Due to insufficient memory in vm could not get a successful build. It fails with the same error even without my changes

@aninda-al aninda-al requested a review from a team as a code owner May 28, 2025 00:49
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels May 28, 2025
@aninda-al aninda-al force-pushed the v-anipradhan/nodejs/CVE-2025-23165-CVE-2025-23166 branch from a94efb1 to 56541ef Compare May 30, 2025 13:11
Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build. Both the patches match with upstream reference. As the patches referenced here are already merged in nodejs 20.19.2 which is a minor version upgrade, could you please check how many of the CVEs listed in spec file are already fixed in 20.19.2 version? There are multiple other fixes in the release, let's see if all the CVEs are fixed and no regressions, then we will try a minor version upgrade. As per, https://nodejs.org/en/about/previous-releases, Node20 series is under Maintenance.

@aninda-al
Copy link
Copy Markdown
Contributor Author

Buddy build. Both the patches match with upstream reference. As the patches referenced here are already merged in nodejs 20.19.2 which is a minor version upgrade, could you please check how many of the CVEs listed in spec file are already fixed in 20.19.2 version? There are multiple other fixes in the release, let's see if all the CVEs are fixed and no regressions, then we will try a minor version upgrade. As per, https://nodejs.org/en/about/previous-releases, Node20 series is under Maintenance.

@kgodara912 I did search the commit logs and found that some of the CVEs we include in our sepc file are missing
image

@aninda-al
Copy link
Copy Markdown
Contributor Author

Buddy build. Both the patches match with upstream reference. As the patches referenced here are already merged in nodejs 20.19.2 which is a minor version upgrade, could you please check how many of the CVEs listed in spec file are already fixed in 20.19.2 version? There are multiple other fixes in the release, let's see if all the CVEs are fixed and no regressions, then we will try a minor version upgrade. As per, https://nodejs.org/en/about/previous-releases, Node20 series is under Maintenance.

@kgodara912 I did search the commit logs and found that some of the CVEs we include in our sepc file are missing image

@kgodara912 It appears from the git log, not all CVEs are applied. Should we still proceed with minor version upgrade or continue applying this patch? Thanks!

Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we could check the source code and see what patches are required but that will take significant time. We may take that up in next release. LGTM.

Copy link
Copy Markdown
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep this PR going for now.

@0xba1a 0xba1a merged commit ae3f157 into microsoft:3.0-dev Jun 10, 2025
15 checks passed
AkarshHCL pushed a commit to AkarshHCL/azurelinux that referenced this pull request Jul 31, 2025
SumitJenaHCL pushed a commit to SumitJenaHCL/azurelinux that referenced this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants