[MEDIUM] Patch nodejs for CVE-2025-23165 CVE-2025-23166#13901
Conversation
a94efb1 to
56541ef
Compare
kgodara912
left a comment
There was a problem hiding this comment.
Buddy build. Both the patches match with upstream reference. As the patches referenced here are already merged in nodejs 20.19.2 which is a minor version upgrade, could you please check how many of the CVEs listed in spec file are already fixed in 20.19.2 version? There are multiple other fixes in the release, let's see if all the CVEs are fixed and no regressions, then we will try a minor version upgrade. As per, https://nodejs.org/en/about/previous-releases, Node20 series is under Maintenance.
@kgodara912 I did search the commit logs and found that some of the CVEs we include in our sepc file are missing |
@kgodara912 It appears from the git log, not all CVEs are applied. Should we still proceed with minor version upgrade or continue applying this patch? Thanks! |
kgodara912
left a comment
There was a problem hiding this comment.
Ideally, we could check the source code and see what patches are required but that will take significant time. We may take that up in next release. LGTM.
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
We can keep this PR going for now.


Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Address CVE-2025-23165 CVE-2025-23166
CVE-2025-23166 Upstream Patch Reference: nodejs/node@6c57465
CVE-2025-23165 Upstream Patch Reference: nodejs/node@9e13bf0
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology