Skip to content

[dev] Update zstd to v1.5.0#1539

Merged
1 commit merged intodevfrom
thcrain/workingdir
Oct 14, 2021
Merged

[dev] Update zstd to v1.5.0#1539
1 commit merged intodevfrom
thcrain/workingdir

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 14, 2021

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Update zstd from version 1.4.4 to latest upstream version 1.5.0 as part of our toolchain package upgrade efforts. Release changelog can be found here.

Change Log
  • zstd: Upgrade to latest upstream version
  • zstd: Change license tag to properly reflect dual licensing situation
  • zstd: Remove licenses from main package (redundant, pulled in through libs subpackage)
  • zstd: Lint spec
Does this affect the toolchain?

YES

Test Methodology
  • Local toolchain build

@ghost ghost self-requested a review October 14, 2021 16:49
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd ask @anphel31 to take a look as well, since it's a change to the toolchain.

@ghost ghost merged commit abf0a99 into dev Oct 14, 2021
@ghost ghost deleted the thcrain/workingdir branch October 14, 2021 20:55
henryli001 pushed a commit that referenced this pull request Feb 25, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants