Skip to content

Conversation

@Kanishk-Bansal
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

NO

Associated issues
  • N/A
Links to CVEs
Test Methodology

Signed-off-by: Kanishk Bansal <kanbansal@microsoft.com>
@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner January 6, 2026 11:17
@Kanishk-Bansal Kanishk-Bansal added security CVE-fixed-by-upgrade CVE fixed by package upgrade labels Jan 6, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Jan 6, 2026
@Kanishk-Bansal Kanishk-Bansal changed the title Upgrade libsodium to 1.0.20 for CVE-2025-69277 [Medium] Upgrade libsodium to 1.0.19-FINAL for CVE-2025-69277 [Medium] Jan 6, 2026
@Kanishk-Bansal Kanishk-Bansal force-pushed the kanbansal/libsodium/CVE-2025-69277 branch 4 times, most recently from b007555 to 35a36cc Compare January 6, 2026 15:21
Signed-off-by: Kanishk Bansal <kanbansal@microsoft.com>
@Kanishk-Bansal Kanishk-Bansal force-pushed the kanbansal/libsodium/CVE-2025-69277 branch from 35a36cc to 2ccc54a Compare January 6, 2026 16:55
@Kanishk-Bansal
Copy link
Contributor Author

@Kanishk-Bansal
Copy link
Contributor Author

libsodium released 1.0.19-FINAL pointer release which has the CVE fix. This is in their practise to release -stable and -final release for any CVE fixes. The commit jedisct1/libsodium@9368c26 shows that the fix has been taken to 1.0.19-FINAL for which I have uploaded a tarball at blob storage with -final to fix this CVE as a part of upgrade

@mayankfz
Copy link
Contributor

mayankfz commented Jan 7, 2026

changes looks fine, buddy build passes.

@mayankfz mayankfz added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Jan 7, 2026
Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream versioning for libsodium is a little different than the normal packages. They don't update version number for the fix as explained in above comment. Buddy build is successful. LGTM.

Name: libsodium
Version: 1.0.19
Release: 1%{?dist}
Release: 2
Copy link
Contributor

@kgodara912 kgodara912 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to same as above with 2%{?dist}

@Kanishk-Bansal
Copy link
Contributor Author

Buddy Build

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build is successful. The upstream libsodium project versioning is different than other general upstream packages. The new source code is fixing the CVE. Also, as per the release notes, it is guaranteed to be compatible with the previous 1.0.19 series releases. LGTM.

@kgodara912 kgodara912 merged commit ba9017d into 3.0-dev Jan 12, 2026
32 checks passed
@kgodara912 kgodara912 deleted the kanbansal/libsodium/CVE-2025-69277 branch January 12, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 CVE-fixed-by-upgrade CVE fixed by package upgrade Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants