fix: add upstream set_context patch to crash-gcore#15453
Merged
jslobodzian merged 2 commits into3.0-devfrom Jan 7, 2026
Merged
fix: add upstream set_context patch to crash-gcore#15453jslobodzian merged 2 commits into3.0-devfrom
jslobodzian merged 2 commits into3.0-devfrom
Conversation
microsoft-github-policy-service
bot
added
Packaging
3.0-dev
The recent crash v9.0.0 update also updated the definition for set_context to add a 3rd parameter. This change created a build break for crash-gcore-command which was using the older set_context definition. Apply the recent upstream crash-gcore commit that fixes the build break. Signed-off-by: Chris Co <chrco@microsoft.com>
christopherco
force-pushed
the
chrco/crash-gcore-fix
branch
from
32300c8 to
d7fa9bc
Compare
Signed-off-by: Chris Co <chrco@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build break in crash-gcore-command caused by the recent crash v9.0.0 update. The crash v9.0.0 update modified the set_context() function to accept a third parameter, which broke compatibility with crash-gcore-command that was still using the old two-parameter signature.
Key Changes:
- Applied upstream patch from crash-gcore to update
set_context()calls with the new three-parameter signature - Updated BuildRequires and Requires dependencies from crash >= 7.2.5 to crash >= 9.0.0
- Incremented the Release tag from 2 to 3
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| SPECS/crash-gcore-command/set_context-third-arg.patch | New patch file adding FALSE as third parameter to set_context() calls to fix build compatibility with crash v9.0.0 |
| SPECS/crash-gcore-command/crash-gcore-command.spec | Updated release number, added patch reference, updated crash dependency version requirements, improved patch application documentation, and added changelog entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jslobodzian
approved these changes
Jan 7, 2026
sandeepkarambelkar
pushed a commit
that referenced
this pull request
Jan 8, 2026
Signed-off-by: Chris Co <chrco@microsoft.com>
sandeepkarambelkar
pushed a commit
that referenced
this pull request
Jan 9, 2026
Signed-off-by: Chris Co <chrco@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
The recent crash v9.0.0 update also updated the definition for set_context to add a 3rd parameter. This change created a build break for crash-gcore-command which was using the older set_context definition.
Apply the recent upstream crash-gcore commit that fixes the build break.
Fixes: eab04d9 ("crash: update to 9.0.0 and rework how vendored gdb patches are applied (#15426)")
Signed-off-by: Chris Co chrco@microsoft.com
Does this affect the toolchain?
NO
Associated issues
Test Methodology