Fix npm coexistence with respective nodejs versions#15777
Fix npm coexistence with respective nodejs versions#15777jslobodzian merged 13 commits intofasttrack/3.0from
Conversation
|
Verified the RPMs installation and confirmed that after recent changes npm routes to nodejs-npm version 20.14.0-13.azl3 whereas if we need 24 version, we need to use npm24. sandeep@marinerDevVM [ ~/nodejs24/RPMS ]$ sudo tdnf install npm Installing: Total installed size: 61.17M Installing: Total installed size: 77.04M |
There was a problem hiding this comment.
Pull request overview
Updates the Node.js 24 spec to avoid clashes with the existing npm packaging model by splitting/renaming the npm subpackage and adding conflict metadata.
Changes:
- Bump
nodejs24release to-2. - Rename the
nodejs24npm subpackage fromnpmtonpm24, and addConflicts: npm. - Use
%{_smp_build_ncpus}for theJOBSbuild setting instead of a hardcoded value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
Changes LGTM and RPM is verified as well, Before merging kindly check https://github.com/microsoft/azurelinux/pull/15777/changes#r2792082422
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Renamed npm subpackage to npm and updated provided capability from npm to nodejs24-npm.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I have verified the package provides constraints using the generated RPMs - sandeep@marinerDevVM [ ~/nodejs24/RPMS ]$ sudo tdnf install nodejs24-npm Installing: Total installed size: 77.04M Installing: Total installed size: 61.17M Installing: Total installed size: 50.64M Installing: Total installed size: 61.17M Installing: Total installed size: 77.04M
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 2b70c39)
|
Auto cherry-pick results:
Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1048112&view=results |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Fix npm coexistence with respective nodejs versions
The npm version constraint causing conflict due to nodejs24 addition.
Made changes to mark npm24 distinct from previous npm and added conflict between the two.
Change Log
Does this affect the toolchain?
NO
Test Methodology