Skip to content

[Medium] Patch mysql for CVE-2025-0838#15867

Merged
kgodara912 merged 7 commits intomicrosoft:3.0-devfrom
v-aaditya:topic_mysql-3.0
Mar 19, 2026
Merged

[Medium] Patch mysql for CVE-2025-0838#15867
kgodara912 merged 7 commits intomicrosoft:3.0-devfrom
v-aaditya:topic_mysql-3.0

Conversation

@v-aaditya
Copy link
Copy Markdown
Contributor

@v-aaditya v-aaditya commented Feb 17, 2026

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch mysql for CVE-2025-0838

Change Log
  • modified: SPECS/mysql/mysql.spec
  • added: SPECS/mysql/CVE-2025-0838.patch
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Local build could not be completed due to resource limitation.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Feb 17, 2026
@v-aaditya
Copy link
Copy Markdown
Contributor Author

@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

as the ptest is known failure and we have skipped it in 2.0 as well. Can you skip it here as well? Even fedora has skipped the tests.

@v-aaditya
Copy link
Copy Markdown
Contributor Author

as the ptest is known failure and we have skipped it in 2.0 as well. Can you skip it here as well? Even fedora has skipped the tests.
Skipped the ptests by updating the spec file.

@v-aaditya v-aaditya marked this pull request as ready for review February 17, 2026 08:40
@v-aaditya v-aaditya requested a review from a team as a code owner February 17, 2026 08:40
@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

After skipping the known failure cases - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1050530&view=results

@v-aaditya
Copy link
Copy Markdown
Contributor Author

After skipping the known failure cases - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1050530&view=results

The Buddy Build has passed on arm64 but failed on amd64 due to test case failure. The test cases which are getting failed are similar to the ones which were failed in the 1st Buddy Build, although SPEC file is updated as per 2.0 branch.

I am looking into it.

@v-aaditya
Copy link
Copy Markdown
Contributor Author

After skipping the known failure cases - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1050530&view=results

The Buddy Build has passed on arm64 but failed on amd64 due to test case failure. The test cases which are getting failed are similar to the ones which were failed in the 1st Buddy Build, although SPEC file is updated as per 2.0 branch.

I am looking into it.

Hi @Kanishk-Bansal

Till now my observations are as follows -

  1. The test cases which are getting failed are actually failing in earlier builds as well, referred past build test logs.
  2. "merge_large_tests" test-suite which is skipped in latest Buddy build, is actually getting passed in 1st buddy build of this PR.

Now I am investigating, how these test cases are getting passed on 2.0 branch, but getting failed here on 3.0 branch.

@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

Buddy Build

@v-aaditya
Copy link
Copy Markdown
Contributor Author

Buddy Build

Buddy Build has failed again and similar cases failing here as well when compared to 2nd Buddy build. Although when I tried to build locally using containerized rpm build for mysql with latest spec file, only 3 cases were getting failed due to timeout and other reasons.

I am looking into it.

@v-aaditya
Copy link
Copy Markdown
Contributor Author

@v-aaditya
Copy link
Copy Markdown
Contributor Author

v-aaditya commented Feb 27, 2026

Buddy Build has been triggered again - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1058494&view=results

The latest buddy build has failed due to some dead code related to GTEST is present in the file, from where the ptests have been removed. Once the dead code is removed, the Buddy build will pass. Patch file need to be updated.

Kindly note, that no such issues came while executing containerized RPM build locally.

@v-aaditya
Copy link
Copy Markdown
Contributor Author

@v-aaditya
Copy link
Copy Markdown
Contributor Author

Again, triggered the Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1061155&view=results

The latest Buddy Build has passed.
CC: @Kanishk-Bansal

@v-aaditya
Copy link
Copy Markdown
Contributor Author

Again, triggered the Buddy Build with updated patch file - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1063464&view=results

@v-aaditya
Copy link
Copy Markdown
Contributor Author

Again, triggered the Buddy Build with updated patch file - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1063464&view=results

The Buddy Build has failed due to reasons unrelated to this PR. All the Buddy builds which have been triggered today, have same issue.

It has to be re-triggered once the Buddy Build issue is resolved.

@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

Buddy Build

@BinduSri-6522866 BinduSri-6522866 mentioned this pull request Mar 9, 2026
12 tasks
Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Patches apply cleanly
  • Patch looks good w.r.t upstream
  • Test Build passes

Signed-Off by: @mfrw

size_t capacity() const { return common().capacity(); }
- size_t max_size() const { return (std::numeric_limits<size_t>::max)(); }
+ size_t max_size() const {
+ return CapacityToGrowth(MaxValidCapacity<sizeof(slot_type)>());
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good w.r.t upstream

@Kanishk-Bansal Kanishk-Bansal added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Mar 12, 2026
Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't skip test cases which are only failing for one architecture instead, the tests can be conditionally included or excluded. Only large tests was the one which was having issue. Include other test for arm testing. You may apply changes conditionally based on arch, so when arch is not x86, then don't apply the patch so all other architectures can be tested.

@v-aaditya
Copy link
Copy Markdown
Contributor Author

Please don't skip test cases which are only failing for one architecture instead, the tests can be conditionally included or excluded. Only large tests was the one which was having issue. Include other test for arm testing. You may apply changes conditionally based on arch, so when arch is not x86, then don't apply the patch so all other architectures can be tested.

Sure, I will update the spec file accordingly and confirm.

@v-aaditya
Copy link
Copy Markdown
Contributor Author

Updated the spec file.
@Kanishk-Bansal Could you please re-trigger the Buddy Build.

@v-aaditya
Copy link
Copy Markdown
Contributor Author

Please don't skip test cases which are only failing for one architecture instead, the tests can be conditionally included or excluded. Only large tests was the one which was having issue. Include other test for arm testing. You may apply changes conditionally based on arch, so when arch is not x86, then don't apply the patch so all other architectures can be tested.

Hi @kgodara912
I have updated the spec file and now the patch only applies on x86_64 arch.
The latest Buddy Build has been triggered and has passed !
I have also referred the same in generated logs and verified that the patch only applies on amd64 and it does not apply on arm64.

Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream patch is backported with adaptation to the existing version. Buddy build is successful. The test failures were specific to x86 and are addressed in this along with flaky merge_large_tests test . LGTM.

@kgodara912 kgodara912 merged commit d03ae43 into microsoft:3.0-dev Mar 19, 2026
17 checks passed
BinduSri-6522866 pushed a commit to BinduSri-6522866/azurelinux that referenced this pull request Mar 31, 2026
AkarshHCL pushed a commit to AkarshHCL/azurelinux that referenced this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants