Skip to content

Upgrade frr to version 10.5.0#15879

Merged
jslobodzian merged 1 commit into3.0-devfrom
sudipta/upgrade-frr-10-5
Mar 26, 2026
Merged

Upgrade frr to version 10.5.0#15879
jslobodzian merged 1 commit into3.0-devfrom
sudipta/upgrade-frr-10-5

Conversation

@realsdx
Copy link
Copy Markdown
Contributor

@realsdx realsdx commented Feb 17, 2026 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?
Customer Request

Change Log
  • Upgrade to version 10.5.0
  • Remove CVE-2024-44070.patch (fixed upstream in 10.5.0)
  • Remove CVE-2024-55553.patch (fixed upstream in 10.5.0)
  • Rebase patches for 10.5.0 compatibility
  • Remove --enable-rtadv and --disable-exampledir (removed upstream)
  • Remove AX_CXX_COMPILE_STDCXX sed workaround (macro removed upstream)
Does this affect the toolchain?

NO

Work Item: Link

Test Methodology
  • Pipeline build id: Buddy Build

@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Feb 17, 2026
@realsdx
Copy link
Copy Markdown
Contributor Author

realsdx commented Feb 17, 2026

Buddy Build

@realsdx realsdx marked this pull request as ready for review February 18, 2026 06:02
@realsdx realsdx requested a review from a team as a code owner February 18, 2026 06:02
mfrw
mfrw reviewed Feb 18, 2026
View reviewed changes
Comment thread SPECS/frr/frr.spec
Name: frr
Version: 9.1.1
Release: 5%{?dist}
Version: 10.5.0
Copy link
Copy Markdown
Member

@mfrw mfrw Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty big jump.
Can we please run a full build to confirm. both for x86_64 & ARM64

Copy link
Copy Markdown
Contributor Author

@realsdx realsdx Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Copy Markdown
Contributor Author

@realsdx realsdx Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full Build

Copy link
Copy Markdown
Contributor Author

@realsdx realsdx Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested image on some LISA tests as well:
verify_openssl_basic
verify_fips_enablement

mfrw
mfrw reviewed Feb 18, 2026
View reviewed changes
Comment thread SPECS/frr/frr.spec
mfrw
mfrw approved these changes Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given the full build is green

@realsdx realsdx added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Feb 20, 2026
@kgodara912
Copy link
Copy Markdown
Contributor

kgodara912 commented Feb 23, 2026

As we have bug for this, please ensure that bug is approved and then we can merge it.

@realsdx
Copy link
Copy Markdown
Contributor Author

realsdx commented Feb 23, 2026

@kgodara912 Which bug? are you asking about the work item?

@kgodara912
Copy link
Copy Markdown
Contributor

kgodara912 commented Feb 23, 2026 •
edited
Loading

Yes, work item will require stable review before merging with signoff.

@kgodara912
Copy link
Copy Markdown
Contributor

kgodara912 commented Mar 11, 2026

There are multiple changes introduced with this much big jump which may break behavior or api by this upgrade. AI summary also says that it may cause outages,

✅ Yes, there are significant breaking changes from 9.1 → 10.5.
❌ This is not a “drop‑in” upgrade if you run BGP seriously.
Most outages reported post‑upgrade trace back to:

AS_SET rejection
IPv6 next‑hop defaults
RPKI strict mode

@realsdx
Copy link
Copy Markdown
Contributor Author

realsdx commented Mar 18, 2026

Update: Waiting for customer signoff

@jslobodzian jslobodzian merged commit 68ce5e6 into 3.0-dev Mar 26, 2026
33 of 37 checks passed
@jslobodzian jslobodzian deleted the sudipta/upgrade-frr-10-5 branch March 26, 2026 15:13
BinduSri-6522866 pushed a commit to BinduSri-6522866/azurelinux that referenced this pull request Mar 31, 2026
@realsdx @BinduSri-6522866
Upgrade frr to version 10.5.0 (microsoft#15879)
50d43d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfrw mfrw mfrw approved these changes

@jslobodzian jslobodzian jslobodzian approved these changes

Assignees

No one assigned

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@realsdx @kgodara912 @mfrw @jslobodzian