Fix ptest regression in python-daemon on arm64 [Work Item: # 16234]#15960
Fix ptest regression in python-daemon on arm64 [Work Item: # 16234]#15960kgodara912 merged 2 commits intomicrosoft:3.0-devfrom
python-daemon on arm64 [Work Item: # 16234]#15960Conversation
python-daemon on arm64 (Work Item: # 16234)
The buddy build has passed on the |
| Subject: Migrate TestCase method to current name ‘assertEqual’. | ||
|
|
||
| Upstream Patch Reference: | ||
| https://pagure.io/python-daemon/c/f5ed6cdd0a9fa3c0ce6d5b862d10da253945e791.patch |
There was a problem hiding this comment.
Can you check this patch is merged in which version of python-daemon, trying to figure out if minor upgrade will fix this?
There was a problem hiding this comment.
version 3.0.2 has been yanked from PyPI
python-daemon on arm64 (Work Item: # 16234)python-daemon on arm64 [Work Item: # 16234]
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
Patch LGTM, it fixes the ptest.
although no breaking changes at v3.1.1, but it is relatively a larger jump.
For now we can proceed with this change
kgodara912
left a comment
There was a problem hiding this comment.
Minor correction in test file to address test failure for updated function name, no functionality change. Buddy build is successful. LGTM.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
The AI analysis was helpful in correctly identifying the root cause of the ptest failure and indicated that the test failure was caused by the removal of the deprecated
unittest.TestCase.assertEquals()API inPython 3.12and recommended updating the test to useassertEqual()instead ofasertEquals().It also confirmed that no changes were needed in the
python‑daemonruntime code. The implemented fix aligns with this recommendation.Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology
Logs:
python-daemon-3.0.1-2.azl3.src.rpm.log
Patch applies cleanly.