Skip to content

Fix ptest regression in python-daemon on arm64 [Work Item: # 16234]#15960

Merged
kgodara912 merged 2 commits intomicrosoft:3.0-devfrom
Ratiranjan5:topic_python-daemon-3.0
Mar 10, 2026
Merged

Fix ptest regression in python-daemon on arm64 [Work Item: # 16234]#15960
kgodara912 merged 2 commits intomicrosoft:3.0-devfrom
Ratiranjan5:topic_python-daemon-3.0

Conversation

@Ratiranjan5
Copy link
Copy Markdown
Contributor

@Ratiranjan5 Ratiranjan5 commented Feb 24, 2026

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

The AI analysis was helpful in correctly identifying the root cause of the ptest failure and indicated that the test failure was caused by the removal of the deprecated unittest.TestCase.assertEquals() API in Python 3.12 and recommended updating the test to use assertEqual() instead of asertEquals().
It also confirmed that no changes were needed in the python‑daemon runtime code. The implemented fix aligns with this recommendation.

Change Log
  • new file: SPECS/python-daemon/python-daemon-3.0.1-fix-ptest-deprecated-assertEquals-with-assertEqual.patch
  • modified: SPECS/python-daemon/python-daemon.spec
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Local build was successful.
image image

@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging specs-extended PR to fix SPECS-EXTENDED Schema Changes to image configurations 3.0 PRs Destined for 3.0 labels Feb 24, 2026
@Ratiranjan5 Ratiranjan5 changed the base branch from 3.0 to 3.0-dev February 24, 2026 06:23
@microsoft-github-policy-service microsoft-github-policy-service Bot added the 3.0-dev PRs Destined for AzureLinux 3.0 label Feb 24, 2026
@Ratiranjan5 Ratiranjan5 changed the title Fix ptest regression in python-daemon on arm64 (TASK 16234) Resolved ptest regression in python-daemon on arm64 (Work Item: # 16234) Feb 24, 2026
@bhagyapathak
Copy link
Copy Markdown
Contributor

bhagyapathak commented Feb 24, 2026

@Ratiranjan5
Copy link
Copy Markdown
Contributor Author

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1055885&view=results

The buddy build has passed on the arm64 architecture as well.

@Ratiranjan5 Ratiranjan5 marked this pull request as ready for review February 24, 2026 10:37
@Ratiranjan5 Ratiranjan5 requested a review from a team as a code owner February 24, 2026 10:37
Subject: Migrate TestCase method to current name ‘assertEqual’.

Upstream Patch Reference:
https://pagure.io/python-daemon/c/f5ed6cdd0a9fa3c0ce6d5b862d10da253945e791.patch
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check this patch is merged in which version of python-daemon, trying to figure out if minor upgrade will fix this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 3.0.2 has been yanked from PyPI

@Ratiranjan5 Ratiranjan5 changed the title Resolved ptest regression in python-daemon on arm64 (Work Item: # 16234) Fix ptest regression in python-daemon on arm64 [Work Item: # 16234] Mar 6, 2026
@Kanishk-Bansal Kanishk-Bansal added the ptest package testing (%check section in spec) label Mar 9, 2026
Copy link
Copy Markdown
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch LGTM, it fixes the ptest.
although no breaking changes at v3.1.1, but it is relatively a larger jump.
For now we can proceed with this change

@Kanishk-Bansal Kanishk-Bansal added ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review and removed Schema Changes to image configurations specs-extended PR to fix SPECS-EXTENDED 3.0 PRs Destined for 3.0 labels Mar 9, 2026
Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor correction in test file to address test failure for updated function name, no functionality change. Buddy build is successful. LGTM.

@kgodara912 kgodara912 merged commit 7d4dc97 into microsoft:3.0-dev Mar 10, 2026
17 checks passed
BinduSri-6522866 pushed a commit to BinduSri-6522866/azurelinux that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ptest package testing (%check section in spec) ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants