workaround(azurelinux-release): simplify spec to address rpmautospec errors

[reubeno]

We're seeing what looks like issues with ternary operators in rpmautospec on koji as well as %autorelease showing up in comments. I can't reproduce it locally but confirmed this update gets things working in koji.

[github-actions]

❌ Spec Review Failed

Type	Count
Errors	3
Warnings	5
Suggestions	4

🛠️ Debug locally: .github/workflows/scripts/README.md

azurelinux-release.spec

❌ Errors (3)

• License file is installed to "licenses/LICENSE" without %{buildroot}; %install must place packaged files under %{buildroot} so %license can include them.
  • 📖 https://rpm-packaging-guide.github.io/
• Symlink %{_sysconfdir}/swid/swidtags.d/microsoft.com is created but not listed in %files, leaving an unowned file.
  • 📖 https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/
• identity-wsl has Requires(meta): azurelinux-release-container, which is inconsistent with other identity variants and likely a wrong dependency for the WSL variant.

⚠️ Warnings (5)

• Summary for identity-wsl ends with a period; Summary should not end with a period.
  • 📖 https://docs.fedoraproject.org/en-US/packaging-guidelines/#summary-and-description
• Description line exceeds 80 columns; description lines should be <= 80 columns.
  • 📖 https://docs.fedoraproject.org/en-US/packaging-guidelines/#summary-and-description
• Description uses "a Azure" (grammar); summary/description should follow American English grammar.
  • 📖 https://docs.fedoraproject.org/en-US/packaging-guidelines/#summary-and-description
• Top-level macros use %define instead of %global; guidelines prefer %global except for rare locally-scoped submacros.
  • 📖 https://docs.fedoraproject.org/en-US/packaging-guidelines/#_global_preferred_over_define
• RELEASE_TYPE is hardcoded to "development" while is_development is defined but unused; release-type should reflect the intended release state.

💡 Suggestions (4)

• Consider using %autorelease for the Release tag as recommended by the versioning guidelines.
  • 📖 https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
• Consider using %autochangelog instead of a manual changelog.
  • 📖 https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
• Use %{_datadir} instead of %{_prefix}/share for the DNF5 config install path to align with RPM path macros.
  • 📖 https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/
• Resolve TODO comments before release (e.g., review markers in the spec).

📄 Raw JSON Report

{
  "spec_reviews": [
    {
      "spec_file": "base/comps/azurelinux-release/azurelinux-release.spec",
      "errors": [
        {
          "description": "License file is installed to \"licenses/LICENSE\" without %{buildroot}; %install must place packaged files under %{buildroot} so %license can include them.",
          "citation": "https://rpm-packaging-guide.github.io/",
          "line": 370
        },
        {
          "description": "Symlink %{_sysconfdir}/swid/swidtags.d/microsoft.com is created but not listed in %files, leaving an unowned file.",
          "citation": "https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/",
          "line": 383
        },
        {
          "description": "identity-wsl has Requires(meta): azurelinux-release-container, which is inconsistent with other identity variants and likely a wrong dependency for the WSL variant.",
          "citation": "N/A",
          "line": 209
        }
      ],
      "warnings": [
        {
          "description": "Summary for identity-wsl ends with a period; Summary should not end with a period.",
          "citation": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#summary-and-description",
          "line": 204
        },
        {
          "description": "Description line exceeds 80 columns; description lines should be <= 80 columns.",
          "citation": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#summary-and-description",
          "line": 102
        },
        {
          "description": "Description uses \"a Azure\" (grammar); summary/description should follow American English grammar.",
          "citation": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#summary-and-description",
          "line": 102
        },
        {
          "description": "Top-level macros use %define instead of %global; guidelines prefer %global except for rare locally-scoped submacros.",
          "citation": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_global_preferred_over_define",
          "line": 1
        },
        {
          "description": "RELEASE_TYPE is hardcoded to \"development\" while is_development is defined but unused; release-type should reflect the intended release state.",
          "citation": "N/A",
          "line": 279
        }
      ],
      "suggestions": [
        {
          "description": "Consider using %autorelease for the Release tag as recommended by the versioning guidelines.",
          "citation": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/",
          "line": 37
        },
        {
          "description": "Consider using %autochangelog instead of a manual changelog.",
          "citation": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs",
          "line": 449
        },
        {
          "description": "Use %{_datadir} instead of %{_prefix}/share for the DNF5 config install path to align with RPM path macros.",
          "citation": "https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/",
          "line": 386
        },
        {
          "description": "Resolve TODO comments before release (e.g., review markers in the spec).",
          "citation": "N/A",
          "line": 8
        }
      ]
    }
  ]
}

[Copilot]

Pull request overview

This PR updates the azurelinux-release RPM spec to avoid Koji/rpmautospec parsing issues by removing %autorelease/%autochangelog usage and simplifying macro logic.

Changes:

• Replace %autorelease with a fixed Release: 2%{?dist}.
• Remove RPM %[ ... ? ... : ...] ternary-based release_type macro usage and hard-code RELEASE_TYPE in generated os-release.
• Replace %autochangelog with a manual %changelog entry.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Changing Release to a fixed 2%{?dist} breaks the spec’s existing prerelease detection (%if %{starts_with "a%{release}" "a0"}) and makes it impossible to represent the documented 0.<r> development numbering. If development builds still need the 0.* scheme, consider making Release: conditional on %{is_development} (using %if/%else) so prerelease labeling continues to work without relying on %autorelease.

Suggested change

	# TODO(azl): Review whether we can move back to autorelease (with conditional -p)
	Release: 2%{?dist}
	# TODO(azl): Review whether we can move back to autorelease (with conditional -p)
	%if %{is_development}
	Release: 0.1%{?dist}
	%else
	Release: 2%{?dist}
	%endif

[Copilot]

This block hard-codes RELEASE_TYPE=development and the TODO references a release_type macro that no longer exists (it was removed above). Also, the spec still defines is_development (with comments indicating it will be toggled for RC/stable releases), so stable builds would incorrectly emit development in /etc/os-release. Consider restoring dynamic generation using RPM conditionals (%if 0%{?is_development} … %else … %endif) instead of the %[ ... ? ... : ...] ternary that Koji/rpmautospec appears to choke on.