Skip to content

Fix ptest for fontconfig#16133

Merged
kgodara912 merged 3 commits intomicrosoft:3.0-devfrom
archana25-ms:topic_ptest-fontconfig
Mar 10, 2026
Merged

Fix ptest for fontconfig#16133
kgodara912 merged 3 commits intomicrosoft:3.0-devfrom
archana25-ms:topic_ptest-fontconfig

Conversation

@archana25-ms
Copy link
Copy Markdown
Contributor

@archana25-ms archana25-ms commented Mar 6, 2026

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Fix ptest for fontconfig

The test was failing at run-test.sh script which tests like MT-safe global config which requires curl/unzip to fetch Noto fonts.

As per the AI analysis, in a constrained CI environment, missing bubblewrap (bwrap) results in those sections being skipped; however other environment dependencies like curl/unzip or access to external network may cause aborts within the "MT-safe global config" block. Also, several checks compare directory mtimes and contents with SOURCE_DATE_EPOCH; differing filesystem semantics can produce mismatches. Without test-suite.log, the most probable subtest failures are those requiring network access and external tools (curl, unzip) or sandboxing via bwrap. The script traps EXIT and will print "Aborting from '' with the exit code" in failure, but this message is not captured in the provided log, suggesting make harness only records the FAIL

Suggested Fix: Ensure CI environment provides required tools and conditions: install or make available curl and unzip; provide internet access or mock Noto font download; if external network not allowed, skip MT-safe global config by disabling that subtest via environment flag or patch.

Hence we have skipped the test using patch provided by https://src.fedoraproject.org/rpms/fontconfig/c/1bacf0fb4436ce5fea7e5db2de0ebb823c1f2471

Change Log
  • SPECS/fontconfig/fontconfig-Replace-curl-with-wget-for-font-zip-download.patch
  • SPECS/fontconfig/fontconfig.spec
Does this affect the toolchain?

NO

Associated issues
Test Methodology
  • Pipeline build id: xxxx
  • With the test patch, build and test is successful
image

@archana25-ms archana25-ms requested a review from a team as a code owner March 6, 2026 10:57
@archana25-ms archana25-ms marked this pull request as draft March 6, 2026 10:57
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Mar 6, 2026
@Kanishk-Bansal Kanishk-Bansal added the ptest package testing (%check section in spec) label Mar 6, 2026
@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

/azurepipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

Buddy Build

@archana25-ms archana25-ms marked this pull request as ready for review March 10, 2026 07:03
@kgodara912
Copy link
Copy Markdown
Contributor

Buddy build

@archana25-ms
Copy link
Copy Markdown
Contributor Author

Buddy build

Buddy Build is successful

Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptest fix for fontconfig. Buddy build is successful after fix. run-test.sh test is passing after excluding the specific sub test as excluded in upstream reference. VERBOSE=1 is not generating many logs and test logs are a little more than normal logs. LGTM.

@kgodara912 kgodara912 merged commit 22ca021 into microsoft:3.0-dev Mar 10, 2026
17 checks passed
BinduSri-6522866 pushed a commit to BinduSri-6522866/azurelinux that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ptest package testing (%check section in spec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants