Skip to content

[Work item #17839] Upgrade buildah to version 1.43.1. Resolved ptests failures#16227

Merged
kgodara912 merged 4 commits into
microsoft:3.0-devfrom
SumitJenaHCL:topic_buildah
Apr 28, 2026
Merged

[Work item #17839] Upgrade buildah to version 1.43.1. Resolved ptests failures#16227
kgodara912 merged 4 commits into
microsoft:3.0-devfrom
SumitJenaHCL:topic_buildah

Conversation

@SumitJenaHCL
Copy link
Copy Markdown
Contributor

@SumitJenaHCL SumitJenaHCL commented Mar 18, 2026

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
This PR is to upgrade the package buildah to version 1.43.0. Along with that, it also addresses the ptests failures mentioned under work item #17839. as the failure suggest 2 issues, one being about the %w format being depreciated and not used by errorResponse so it is replaced with %v. Another issue about missing arguments for %v format which requires 3 arguments.

Change Log
  • SPECS-EXTENDED/buildah/0001-fix-copier-arguments.patch
  • SPECS-EXTENDED/buildah/buildah.signatures.json
  • SPECS-EXTENDED/buildah/buildah.spec
  • cgmanifest.json
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@SumitJenaHCL SumitJenaHCL requested review from a team as code owners March 18, 2026 13:55
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Mar 18, 2026
@Kanishk-Bansal Kanishk-Bansal added the ptest package testing (%check section in spec) label Mar 31, 2026
@SumitJenaHCL SumitJenaHCL force-pushed the topic_buildah branch 2 times, most recently from aede7c8 to 0847ccb Compare March 31, 2026 09:01
@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

Buddy Build

@SumitJenaHCL
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.
If we can update to 1.43.1, we might not need the patch.
Please update and I will upload the latest source and reapprove if needed.

Comment thread SPECS-EXTENDED/buildah/buildah.spec Outdated
# copr and koji builds.
# If you're reading this on dist-git, the version is automatically filled in by Packit.
Version: 1.41.4
Version: 1.43.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try updating to 1.43.1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded package to 1.43.1 as requested. This no longer requires the patch.

@Kanishk-Bansal Kanishk-Bansal added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Apr 23, 2026
@SumitJenaHCL SumitJenaHCL changed the title [Work item #17839] Upgrade buildah to version 1.43.0. Resolved ptests failures [Work item #17839] Upgrade buildah to version 1.43.1. Resolved ptests failures Apr 23, 2026
@sandeepkarambelkar
Copy link
Copy Markdown
Contributor

Add missing newline at end of buildah.signatures.json file
@SumitJenaHCL
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version upgrade in extended repo with few formatting fixes. Buddy build is successful except license warning. LGTM.

@kgodara912 kgodara912 merged commit fb1198c into microsoft:3.0-dev Apr 28, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ptest package testing (%check section in spec) ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants