fix: rust-cssparser0.31: pin to Fedora 43 build commit b6fd5d766320#16393
fix: rust-cssparser0.31: pin to Fedora 43 build commit b6fd5d766320#16393christopherco merged 1 commit intotomls/base/mainfrom
Conversation
Pin rust-cssparser0.31 to upstream commit b6fd5d76632012a8ceb9119dac4f18711fde3fb4 (Fedora dist-git: rust-cssparser) to fetch sources from the commit used to build the current f43 package.
There was a problem hiding this comment.
Pull request overview
Pins the rust-cssparser0.31 component to a specific Fedora 43 dist-git commit so Azure Linux fetches the exact spec/sources used for the current Fedora 43 build, while keeping component registration consistent with the repo’s dedicated *.comp.toml pattern.
Changes:
- Added a dedicated
rust-cssparser0.31.comp.tomldefining an upstream spec pin to Fedora 43 commitb6fd5d76632012a8ceb9119dac4f18711fde3fb4. - Removed the now-redundant empty
rust-cssparser0.31entry fromcomponents-full.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| base/comps/rust-cssparser0.31/rust-cssparser0.31.comp.toml | Introduces the Fedora 43 upstream commit pin for rust-cssparser0.31. |
| base/comps/components-full.toml | Removes the old bare component entry now that a dedicated comp file exists. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| [components.'rust-cssparser0.31'] | |||
| # Pin to the f43 commit used to build the current Fedora 43 package. | |||
There was a problem hiding this comment.
The pin comment should include a direct reference URL to the Fedora dist-git commit being pinned (consistent with other upstream-commit pins, e.g. base/comps/golang/golang.comp.toml). This makes it easier to audit what’s being tracked and when it’s safe to remove the override.
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-cssparser/c/b6fd5d76632012a8ceb9119dac4f18711fde3fb4 |
| # Pin to the f43 commit used to build the current Fedora 43 package. | ||
| # TODO: Drop this override once the default Fedora 43 snapshot | ||
| # in distro/azurelinux.distro.toml advances past this commit. | ||
| spec = { type = "upstream", upstream-name = "rust-cssparser", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "b6fd5d76632012a8ceb9119dac4f18711fde3fb4" } |
There was a problem hiding this comment.
upstream-name = "rust-cssparser" makes the rust-cssparser0.31 component pull the same Fedora dist-git package as the existing [components.rust-cssparser] entry, which is likely to produce duplicate/conflicting RPM outputs and is inconsistent with how other version-suffixed Rust crate components map to Fedora. Unless Fedora’s dist-git for this component is actually named rust-cssparser (and not rust-cssparser0.31), the safer fix is to drop upstream-name so the upstream package name matches the component name; if the mismatch is intentional, it needs a clear comment + reference and a plan to avoid output collisions with rust-cssparser.
| spec = { type = "upstream", upstream-name = "rust-cssparser", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "b6fd5d76632012a8ceb9119dac4f18711fde3fb4" } | |
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "b6fd5d76632012a8ceb9119dac4f18711fde3fb4" } |
Pin rust-cssparser0.31 to upstream commit b6fd5d76632012a8ceb9119dac4f18711fde3fb4 (Fedora dist-git: rust-cssparser) to fetch sources from the commit used to build the current f43 package.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology