fix(golang-github-prometheus-common): add missing jmespath BuildRequires for sigv4 tests#16615
Merged
christopherco merged 1 commit intotomls/base/mainfrom Apr 12, 2026
Conversation
…res for sigv4 tests golang-github-aws-sdk is built in bootstrap mode, which suppresses all golang(...) Requires from its -devel RPM. The sigv4 subpackage imports aws-sdk-go, which transitively needs github.com/jmespath/go-jmespath. Add an explicit BuildRequires so sigv4 tests compile and run. Build verified locally; package inspected in mock.
christopherco
requested review from
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated component overlay for golang-github-prometheus-common to ensure sigv4 tests can build under bootstrap constraints where transitive Go Requires aren’t available from golang-github-aws-sdk’s -devel RPM.
Changes:
- Introduce
golang-github-prometheus-common.comp.tomlwith aspec-add-tagoverlay addingBuildRequires: golang(github.com/jmespath/go-jmespath). - Remove the inline
[components.golang-github-prometheus-common]entry frombase/comps/components.tomlto avoid duplicate component tables (since**/*.comp.tomlfiles are included automatically).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base/comps/golang-github-prometheus-common/golang-github-prometheus-common.comp.toml | Adds an overlay to explicitly pull in the missing jmespath Go module for sigv4 test compilation. |
| base/comps/components.toml | Drops the inline component entry now that the component has a dedicated .comp.toml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anphel31
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golang-github-aws-sdk is built in bootstrap mode, which suppresses all golang(...) Requires from its -devel RPM. The sigv4 subpackage imports aws-sdk-go, which transitively needs github.com/jmespath/go-jmespath. Add an explicit BuildRequires so sigv4 tests compile and run.
Build verified locally; package inspected in mock.