Fix ptest issue for c-ares#16899
Merged
kgodara912 merged 1 commit intomicrosoft:3.0-devfrom Apr 28, 2026
Merged
Conversation
Contributor
Contributor
Author
|
Buddy Build is successful. |
Kanishk-Bansal
approved these changes
Apr 28, 2026
Contributor
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
Upstream removed the acountry utility beginning with c-ares 1.28.0, as it relied on the external service countries.nerd.dk, which is no longer accessible. Therefore, acountry is no longer included or built in recent versions.
Previously, the %check section attempted to run acountry, resulting in test failures. This PR removes that step, while preserving the other tests.
kgodara912
approved these changes
Apr 28, 2026
Contributor
kgodara912
left a comment
There was a problem hiding this comment.
Minor removal for unsupported binary test. Buddy build is successful. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
This PR fixes a ptest failure in c-ares by removing the acountry tool invocation from the %check section.
Upstream has removed the acountry utility starting from c‑ares 1.28.0 because it depended on the external service countries.nerd.dk, which is no longer available. As a result, acountry is no longer built or shipped in current versions.
The %check section previously attempted to run acountry, causing test failures. This PR removes that invocation while keeping the remaining tests intact.
reference-c-ares/c-ares#718
I checked the commits in above link the changes done in upstream commits to remove acountry tool are present in our source code too.
Change Log
Does this affect the toolchain?
NO
Test Methodology