Fix Ptest for Cython.#16915
Conversation
|
Buddy build is successful .It had license warnings which I have resolved now. |
|
Buddy build is successful with no license warnings. |
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
Overly broad sed — sed -i '/\$/s/\$//' Cython/Build/IpythonMagic.py strips the trailing backslash from every line ending in , not only the E502 (redundant-backslash-between-brackets) cases. Legitimate Python line continuations elsewhere in the file would also be silently rewritten.
just change in IpythonMagic.py using a patch
Co-authored-by: Copilot <copilot@github.com>
|
Added a patch instead of sed command. |
|
Buddy Build is successful. |
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
LGTM, The broad sed -i '/\$/s/\$//' was replaced with a patch
kgodara912
left a comment
There was a problem hiding this comment.
Minor line ending fix in test. Buddy build is successful. LGTM.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
The Cython test suite was failing during %check due to a code formatting violation reported by the upstream style checker (TestCodeFormat). The failure specifically originated from a flake8 error:
E502: redundant backslash between brackets
File affected: Cython/Build/IpythonMagic.py
This issue is purely a style/linting problem and does not impact build correctness or runtime functionality. However, since the upstream test suite enforces formatting checks, it caused the overall test execution to fail.
To resolve this we applied a targeted in-place fix during the %check phase using a sed command. This removes trailing backslashes from affected lines, eliminating the E502 violation
Change Log
Does this affect the toolchain?
Yes
Test Methodology