Skip to content

ci(prcheck): split pipeline script into client + thin runner #17064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherco merged 1 commit into from
May 8, 2026
Merged

ci(prcheck): split pipeline script into client + thin runner #17064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ado/sources-upload.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# Name: "ControlTower-PRCheck"
# Required variables:
# - ApiAudience : Entra ID audience URI for the Control Tower app
# - ApiBaseUrl : Base URL of the Control Tower service
# - ApiBaseDirectUrl : Direct base URL of the Control Tower APIM endpoint (bypasses Azure Front Door)
# - AzldevCommit : Commit hash for azldev (go install ...@<commit>)

# Trigger controlled by ADO branch policy — not YAML triggers.
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ado/templates/sources-upload-stages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ stages:
echo "##[endgroup]"

echo "##[group]Python dependencies"
pip install -r .github/workflows/scripts/control-tower-prcheck/requirements.txt
pip install -r .github/workflows/scripts/control-tower/requirements.txt
echo "##[endgroup]"
displayName: "Install dependencies"
env:
Expand Down Expand Up @@ -200,7 +200,7 @@ stages:
inlineScript: |
set -euo pipefail

python3 .github/workflows/scripts/control-tower-prcheck/run_control_tower_prcheck.py \
python3 .github/workflows/scripts/control-tower/run_prcheck.py \
--api-audience "$API_AUDIENCE" \
--api-base-url "$API_BASE_URL" \
--build-reason "$BUILD_REASON" \
Expand All @@ -209,7 +209,7 @@ stages:
--repo-uri "$UPSTREAM_REPO_URL"
env:
API_AUDIENCE: $(ApiAudience)
API_BASE_URL: $(ApiBaseUrl)
API_BASE_URL: $(ApiBaseDirectUrl)
BUILD_REASON: $(Build.Reason)
Comment thread
PawelWMS marked this conversation as resolved.
COMPONENTS: $(components)
SOURCE_COMMIT: $(sourceCommit)
Expand Down
Loading
Loading