Skip to content

Bump icu component version for package nodejs#17358

Merged
kgodara912 merged 2 commits into
microsoft:3.0-devfrom
Kanishk-Bansal:topic_nodejs24-3.0
Jun 3, 2026
Merged

Bump icu component version for package nodejs#17358
kgodara912 merged 2 commits into
microsoft:3.0-devfrom
Kanishk-Bansal:topic_nodejs24-3.0

Conversation

@SumitJenaHCL

@SumitJenaHCL SumitJenaHCL commented May 19, 2026

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
This PR is to bump the icu component version of 78.2

Change Log
  • SPECS/nodejs24/nodejs24.signatures.json
  • SPECS/nodejs24/nodejs24.spec
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels May 19, 2026
@SumitJenaHCL SumitJenaHCL changed the title Bump icu component version Bump icu component version for package nodejs24 May 20, 2026
Comment thread SPECS/nodejs24/nodejs24.spec Outdated
@SumitJenaHCL SumitJenaHCL changed the title Bump icu component version for package nodejs24 Bump icu component version for package nodejs Jun 1, 2026
@SumitJenaHCL SumitJenaHCL requested a review from mayankfz June 1, 2026 07:05
@SumitJenaHCL SumitJenaHCL marked this pull request as ready for review June 1, 2026 10:20
@SumitJenaHCL SumitJenaHCL requested a review from a team as a code owner June 1, 2026 10:20
@SumitJenaHCL

Copy link
Copy Markdown
Author

Verified the ICU version mismatch from #17161 is resolved with this build : https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1130209&view=results

Reproduced the issue's check against the rebuilt nodejs-24.14.1-4.azl3 + nodejs-full-i18n-24.14.1-4.azl3 RPMs on linux/amd64:

image Intl.Segmenter now initializes cleanly — no more U_FILE_ACCESS_ERROR: ... contains icudt78l.dat. Binary (ICU 78) and -full-i18n data file (icudt78l.dat) are consistent on amd64, which was the root cause called out in #17161.

@SumitJenaHCL

Copy link
Copy Markdown
Author

Also verified the segfault repro from #17161 no longer triggers with this build.

Ran the issue's exact TypeSpec reproducer in the OneBranch build image with the rebuilt nodejs-24.14.1-4.azl3 RPMs preinstalled:

image Result: tsp compile runs to completion and docker exit: 0 — no more Segmentation fault / exit 139 that the stock image produces on amd64. Repeated 5 runs back-to-back, all clean.

@mayankfz

mayankfz commented Jun 2, 2026

Copy link
Copy Markdown

BB - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1130209&view=results
Buddy build passes and the issue has been fixed by the changes.

@mayankfz mayankfz added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Jun 2, 2026

@kgodara912 kgodara912 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component version upgrade for nodejs upgrade to 24 to prevent segfaults in particular scenarios. Buddy build is successful. LGTM.

@kgodara912 kgodara912 merged commit 7d9ad45 into microsoft:3.0-dev Jun 3, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants