Pass toolchain archive to make in pipeline template#6640
Merged
dmcilvaney merged 9 commits intomicrosoft:mainfrom Nov 20, 2023
Merged
Conversation
7d5bbda to
ee5cde6
Compare
anphel31
reviewed
Oct 31, 2023
PawelWMS
reviewed
Nov 1, 2023
cwize1
reviewed
Nov 15, 2023
Contributor
Author
|
Will look into suggestions, hadn't had a chance to run a test yet so I'll update and then run a build. |
PawelWMS
reviewed
Nov 15, 2023
PawelWMS
approved these changes
Nov 15, 2023
dmcilvaney
commented
Nov 20, 2023
gmileka
pushed a commit
that referenced
this pull request
Dec 7, 2023
dmcilvaney
added a commit
to dmcilvaney/CBL-Mariner
that referenced
this pull request
Dec 14, 2023
dmcilvaney
added a commit
to dmcilvaney/CBL-Mariner
that referenced
this pull request
Dec 14, 2023
dmcilvaney
added a commit
to dmcilvaney/CBL-Mariner
that referenced
this pull request
Dec 14, 2023
rlmenge
pushed a commit
that referenced
this pull request
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
The toolkit should generally be called with a static set of inputs, we are using
TOOLCHAIN_ARCHIVE=./path/to/toolchain.tar.gzwhen we callmake toolchain. We should continue to use the same input for future commands. Generally we won't re-create the toolchain .rpms since nothing will cause a rebuild, but we should be defensive. If something DOES change, without settingTOOLCHAIN_ARCHIVEthe toolkit will assume it should download the .rpms. This may fail if one of the toolchain packages has been bumped and was rebuild in the previous stage.If we pass
TOOLCHAIN_ARCHIVEto all commnads that use the toolchain the toolkit will know to extract antying that is missing from the archive instead of trying to download a missing file from PMC.Change Log
TOOLCHAIN_ARCHIVEto the"Build packages"stage ofPackageBuild.yml.Does this affect the toolchain?
NO
Associated issues
Test Methodology