Skip to content

Added patch for CVE-2023-46136 to python-werkzeug#6669

Merged
nisamson merged 25 commits intofasttrack/2.0from
nisamson/CVE-2023-46136
Nov 20, 2023
Merged

Added patch for CVE-2023-46136 to python-werkzeug#6669
nisamson merged 25 commits intofasttrack/2.0from
nisamson/CVE-2023-46136

Conversation

@nisamson
Copy link
Copy Markdown
Member

@nisamson nisamson commented Nov 3, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Upgrades and adds patch to python-werkzeug to fix CVE-2023-46136

Change Log

Upgrades python-werkzeug to 2.3.7
Patches CVE-2023-46136 in python-werkzeug

Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Pipeline build id: 451961 Unified-Buddy-Build

@nisamson nisamson requested a review from a team as a code owner November 3, 2023 23:51
@mfrw mfrw added the security label Nov 7, 2023
@PawelWMS
Copy link
Copy Markdown
Contributor

PawelWMS commented Nov 8, 2023

@nisamson, just a heads-up: all PRs against fasttrack/2.0 should be rebased, since we finished a monthly update, which also updated fasttrack/2.0. Rebasing (or merging) the latest state of the branch will re-trigger the PR check and allow us to validate that the latest state of the repo still builds correctly with the changes from the PRs.

Group: Development/Languages/Python
URL: https://github.com/pallets/werkzeug
Source0: https://github.com/pallets/werkzeug/archive/%{version}.tar.gz#/werkzeug-%{version}.tar.gz
#Source0: werkzeug-%{version}.tar.gz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean-up:

Suggested change
#Source0: werkzeug-%{version}.tar.gz

Comment thread SPECS/python-werkzeug/python-werkzeug.spec
@nisamson nisamson requested a review from a team November 14, 2023 01:31
Copy link
Copy Markdown
Contributor

@sameluch sameluch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

Comment thread SPECS/python-werkzeug/python-werkzeug.spec Outdated
@PawelWMS PawelWMS requested review from a team as code owners November 18, 2023 02:39
%check
pip3 install pytest hypothesis
LANG=en_US.UTF-8 PYTHONPATH=./ python3 setup.py test
pip3 install tox==4.6.3 tox-current-env
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw. why do we need to pin this to an older version? I'm not saying it's wrong, but let's leave a comment.

@nisamson nisamson merged commit 98edc7e into fasttrack/2.0 Nov 20, 2023
@nisamson nisamson deleted the nisamson/CVE-2023-46136 branch November 20, 2023 04:13
CBL-Mariner-Bot pushed a commit that referenced this pull request Nov 20, 2023
Co-authored-by: Nick Samson <nisamson@microsoft.com>
Co-authored-by: Nan Liu <108544011+liunan-ms@users.noreply.github.com>
(cherry picked from commit 98edc7e)
@CBL-Mariner-Bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants