kubernetes: fix version subcommand for components#6722
Merged
Conversation
The KUBE_GIT_VERSION_FILE seems to be not present in the release. Use the alternative KUBE_GIT_VERSION instead. Fixes: #6719 Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
9dc3b03 to
d5828af
Compare
tobiasb-ms
requested changes
Nov 14, 2023
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
tobiasb-ms
approved these changes
Nov 14, 2023
hbeberman
approved these changes
Nov 14, 2023
gmileka
pushed a commit
that referenced
this pull request
Dec 7, 2023
The KUBE_GIT_VERSION_FILE seems to be not present in the release. Use the alternative KUBE_GIT_VERSION instead. Fixes: #6719 Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Fixes: #6719
The KUBE_GIT_VERSION_FILE seems to be not present in the release.
Use the alternative KUBE_GIT_VERSION instead.
Reference: https://github.com/kubernetes/kubernetes/blob/v1.28.3/hack/lib/version.sh#L26
Change Log
versionsubcommand for componentsDoes this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology
RUN_CHECK=y& verified with an install in a AzureLinux VM