Fixed signature checking for local sources to break the build on a mismatch.#6737
Merged
PawelWMS merged 8 commits intomicrosoft:mainfrom Nov 17, 2023
Merged
Conversation
dmcilvaney
reviewed
Nov 13, 2023
dmcilvaney
reviewed
Nov 13, 2023
dmcilvaney
reviewed
Nov 14, 2023
dmcilvaney
approved these changes
Nov 14, 2023
dmcilvaney
approved these changes
Nov 14, 2023
anphel31
approved these changes
Nov 15, 2023
gmileka
pushed a commit
that referenced
this pull request
Dec 7, 2023
dmcilvaney
pushed a commit
to dmcilvaney/CBL-Mariner
that referenced
this pull request
Dec 14, 2023
dmcilvaney
pushed a commit
to dmcilvaney/CBL-Mariner
that referenced
this pull request
Dec 14, 2023
dmcilvaney
pushed a commit
to dmcilvaney/CBL-Mariner
that referenced
this pull request
Dec 14, 2023
rlmenge
pushed a commit
that referenced
this pull request
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Our tooling is expected to fail the build by default in case of a spec source signature mismatch. Right now we were ignoring the errors returned by out validation logic for local files and only displayed a warning.
Change Log
Does this affect the toolchain?
No.
Test Methodology