Image Customizer: Implement fallback partition customization.#6747
Merged
cwize1 merged 5 commits intomicrosoft:mainfrom Nov 29, 2023
Merged
Conversation
gmileka
reviewed
Nov 13, 2023
gmileka
reviewed
Nov 13, 2023
gmileka
reviewed
Nov 13, 2023
elainezhao1
reviewed
Nov 18, 2023
elainezhao1
reviewed
Nov 18, 2023
romoh
reviewed
Nov 27, 2023
romoh
reviewed
Nov 27, 2023
romoh
reviewed
Nov 27, 2023
romoh
reviewed
Nov 27, 2023
Contributor
|
😎👍 awesome job on test coverage & unit tests |
romoh
reviewed
Nov 28, 2023
This change implements the default/fallback logic for partition customization. This will be used when the partition layout changes are too complex for modifying the partitions directly. The fallback logic creates the desired partition layout and then does a file copy from the base image to the new image. After that, some minor fix-ups are done (e.g. configuring the boot-loader). The Image Customizer partition config schema mostly mirrors that of the new-image config. Some features were not included (e.g. dm-verity, encryption, overlays) to avoid making a large change even larger. In addition, a lot of additional config validity checks were added to try to limit it to only things that are known to work.
cwize1
force-pushed
the
user/chrisgun/ImageCustomizerFallbackPartitions
branch
from
e332f62 to
6314b16
Compare
romoh
approved these changes
Nov 29, 2023
elainezhao1
approved these changes
Nov 29, 2023
gmileka
pushed a commit
that referenced
this pull request
Dec 7, 2023
dmcilvaney
pushed a commit
to dmcilvaney/CBL-Mariner
that referenced
this pull request
Dec 14, 2023
dmcilvaney
pushed a commit
to dmcilvaney/CBL-Mariner
that referenced
this pull request
Dec 14, 2023
dmcilvaney
pushed a commit
to dmcilvaney/CBL-Mariner
that referenced
this pull request
Dec 14, 2023
dmcilvaney
pushed a commit
to dmcilvaney/CBL-Mariner
that referenced
this pull request
Dec 14, 2023
rlmenge
pushed a commit
that referenced
this pull request
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
This change implements the default/fallback logic for partition customization. This will be used when the partition layout changes are too complex for modifying the partitions directly.
The fallback logic creates the desired partition layout and then does a file copy from the base image to the new image. After that, some minor fix-ups are done (e.g. configuring the boot-loader).
The Image Customizer partition config schema mostly mirrors that of the new-image config. Some features were not included (e.g. dm-verity, encryption, overlays) to avoid making a large change even larger. In addition, a lot of additional config validity checks were added to try to limit it to only things that are known to work.
Change Log
Does this affect the toolchain?
NO
Test Methodology