Skip to content

Update kernel-mshv, kernel-uvm, kernel-uvm-cvm BuildRequires to inclu…#6816

Merged
rlmenge merged 1 commit intomainfrom
rlmenge/2.0/kernel-kata/cpio
Nov 21, 2023
Merged

Update kernel-mshv, kernel-uvm, kernel-uvm-cvm BuildRequires to inclu…#6816
rlmenge merged 1 commit intomainfrom
rlmenge/2.0/kernel-kata/cpio

Conversation

@rlmenge
Copy link
Copy Markdown
Contributor

@rlmenge rlmenge commented Nov 21, 2023

…de cpio

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Update kernel-mshv, kernel-uvm, kernel-uvm-cvm BuildRequires to include cpio

Similar to 1f4f655

When testing kernel builds in the latest Mariner 2.0 container, it was noted that the list of kernel's BuildRequires is missing cpio. The container (unlike our core images used in VMs) does not include "cpio" by default as defined in core-package.spec. This led to kheaders errors:

make[1]: *** [kernel/Makefile:160: kernel/kheaders_data.tar.xz] Error 127
make: *** [Makefile:1907: kernel] Error 2

Therefore, add as a buildRequires.

Note that cpio is also listed as a minimal requirement for the kernel to build: https://www.kernel.org/doc/html/latest/process/changes.html?highlight=cpio

Change Log
  • Update kernel-mshv, kernel-uvm, kernel-uvm-cvm BuildRequires to include cpio
Does this affect the toolchain?

NO

Associated issues
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Nov 21, 2023
@rlmenge rlmenge marked this pull request as ready for review November 21, 2023 08:06
@rlmenge rlmenge requested review from a team as code owners November 21, 2023 08:06
@rlmenge rlmenge merged commit ffbf91e into main Nov 21, 2023
@rlmenge rlmenge deleted the rlmenge/2.0/kernel-kata/cpio branch November 21, 2023 17:53
gmileka pushed a commit that referenced this pull request Dec 7, 2023
#6816)

Similar to 1f4f655

When testing kernel builds in the latest Mariner 2.0 container, it was noted that the list of kernel's BuildRequires is missing cpio. The container image (unlike our core images used in VMs) does not include "cpio" by default as defined in core-package.spec. This led to kheaders errors:

make[1]: *** [kernel/Makefile:160: kernel/kheaders_data.tar.xz] Error 127
make: *** [Makefile:1907: kernel] Error 2

Therefore, add cpio as a buildRequires.

Note that cpio is also listed as a minimal requirement for the kernel to build: https://www.kernel.org/doc/html/latest/process/changes.html?highlight=cpio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants