Skip to content

Enable CONFIG_ARM_SMMU and CONFIG_ARM_SMMU_V3 in aarch64.#6823

Closed
ddaney-fungible wants to merge 7 commits intomicrosoft:2.0from
ddaney-fungible:enable-aarch64-iommu
Closed

Enable CONFIG_ARM_SMMU and CONFIG_ARM_SMMU_V3 in aarch64.#6823
ddaney-fungible wants to merge 7 commits intomicrosoft:2.0from
ddaney-fungible:enable-aarch64-iommu

Conversation

@ddaney-fungible
Copy link
Copy Markdown
Contributor

@ddaney-fungible ddaney-fungible commented Nov 21, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Enable IOMMU in aarch64 kernel. It is needed to allow VFIO to be used with Mariner.

Change Log
  • Enable CONFIG_ARM_SMMU and CONFIG_ARM_SMMU_V3 in aarch64 kernel.
Does this affect the toolchain?

NO

Associated issues
Test Methodology
  • local build

@ddaney-fungible ddaney-fungible requested a review from a team as a code owner November 21, 2023 22:56
@ddaney-fungible ddaney-fungible requested a review from a team as a code owner November 21, 2023 23:31
@charles-gray
Copy link
Copy Markdown

Nice!!

@christopherco
Copy link
Copy Markdown
Collaborator

Hi @ddaney-fungible thanks for the contribution! I will request to retarget your PR to our main branch instead of the 2.0 branch.
main is our 2.0 development branch so changes will flow there first.

Copy link
Copy Markdown
Collaborator

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple other comments, but aside from retargeting to main, the changes seem reasonable to me. Once retargeted, @rlmenge let's kick off our official buddy builds to test fully out this change

Note: We'll also want to make sure this change gets cherry-picked into our 3.0-dev branch as well, so it is part of our next major 3.0 release. But let's first get this PR evaluated/merged into our main branch

Comment thread SPECS/kernel/kernel.spec
Name: kernel
Version: 5.15.137.1
Release: 1%{?dist}
Release: 2%{?dist}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a corresponding changelog entry in the %changelog section for this -2 release increment

Name: kernel-headers
Version: 5.15.137.1
Release: 1%{?dist}
Release: 2%{?dist}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a corresponding changelog entry in the %changelog section for this -2 release increment

Name: kernel-signed-%{buildarch}
Version: 5.15.137.1
Release: 1%{?dist}
Release: 2%{?dist}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a corresponding changelog entry in the %changelog section for this -2 release increment

@ddaney-fungible
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback, I don't know how to change the branch target of a PR, so I am going to close this one and open a new one for the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants