Skip to content

Add package double-conversion to SPECS#6825

Merged
sindhu-karri merged 2 commits intomainfrom
sindhu/add_package_double_conversion
Nov 27, 2023
Merged

Add package double-conversion to SPECS#6825
sindhu-karri merged 2 commits intomainfrom
sindhu/add_package_double_conversion

Conversation

@sindhu-karri
Copy link
Copy Markdown
Contributor

@sindhu-karri sindhu-karri commented Nov 22, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
The PR adds double-conversion package to Mariner SPECS
Double-conversion is a C++ library for converting given strings to floats/doubles and vice versa.
This is required library to build a customer package (Folly)

Change Log
  • Initial CBL-Mariner import from Fedora 38 (license: MIT)
  • Source license verified: BSD
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Nov 22, 2023
@sindhu-karri sindhu-karri marked this pull request as ready for review November 22, 2023 11:22
@sindhu-karri sindhu-karri requested a review from a team as a code owner November 22, 2023 11:22
Copy link
Copy Markdown
Contributor

@rakshaa2000 rakshaa2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sindhu-karri sindhu-karri merged commit 7f29342 into main Nov 27, 2023
@sindhu-karri sindhu-karri deleted the sindhu/add_package_double_conversion branch November 27, 2023 15:02
gmileka pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants