Bugfix - Skip Dracut Module and Mariner.cfg Update with no Verity Cfg.#7234
Merged
Bugfix - Skip Dracut Module and Mariner.cfg Update with no Verity Cfg.#7234
Conversation
vinceaperri
approved these changes
Jan 11, 2024
romoh
approved these changes
Jan 11, 2024
Contributor
|
Can you please update / clean up the PR description? |
mfrw
reviewed
Jan 12, 2024
| } | ||
|
|
||
| err = enableVerityPartition(imageChroot) | ||
| err = enableVerityPartition(config.SystemConfig.Verity, imageChroot) |
Member
There was a problem hiding this comment.
+1 on doing the check before the function call to avoid adding an argument.
Contributor
|
Thanks for this change. LGTM! Once the merge happens, please also update the corresponding artifact. |
jiria
approved these changes
Jan 13, 2024
anphel31
approved these changes
Jan 13, 2024
Member
anphel31
left a comment
There was a problem hiding this comment.
Please fill out the PR description, and in particular ensure the "sudo make go-tidy-all and sudo make go-test-coverage" tests pass
cwize1
pushed a commit
that referenced
this pull request
Jan 18, 2024
#7234) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
cwize1
pushed a commit
that referenced
this pull request
Jan 18, 2024
#7234) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
BettyRain
pushed a commit
that referenced
this pull request
Jan 23, 2024
#7234) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
BettyRain
pushed a commit
that referenced
this pull request
Jan 26, 2024
#7234) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
sharath-srikanth-chellappa
pushed a commit
that referenced
this pull request
Jan 26, 2024
#7234) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
sharath-srikanth-chellappa
pushed a commit
that referenced
this pull request
Jan 26, 2024
#7234) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
sharath-srikanth-chellappa
pushed a commit
that referenced
this pull request
Jan 26, 2024
#7234) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
BettyRain
pushed a commit
that referenced
this pull request
Jan 27, 2024
#7234) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
Adub17030MS
pushed a commit
that referenced
this pull request
Feb 9, 2024
#7234) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
Xiaohong-Deng
pushed a commit
to Xiaohong-Deng/azurelinux
that referenced
this pull request
Nov 23, 2024
microsoft#7234) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix - Skip Dracut Module and Mariner.cfg Update with no Verity Cfg.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Title says, skip Dracut module re-building and Mariner.cfg updating when users do NOT customize Verity related configs.
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology
Internal Bug Ticket Number: 6515