Skip to content

Making GitHub Actions' permissions explicit.#7282

Merged
PawelWMS merged 3 commits intomicrosoft:mainfrom
PawelWMS:pawelwi/actions_explicit_permissions
Jan 17, 2024
Merged

Making GitHub Actions' permissions explicit.#7282
PawelWMS merged 3 commits intomicrosoft:mainfrom
PawelWMS:pawelwi/actions_explicit_permissions

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS commented Jan 17, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

In February the default permissions for the GITHUB_TOKEN embedded in all GitHub Actions will change to a default read-only. This PR verifies this change won't break any of our existing Actions as well as make the read-only permission explicit, so it's easier to see what permissions we're running with.

Change Log
  • Added permissions: read-all to all GitHub Actions.
Does this affect the toolchain?

No.

Test Methodology
  • Ran checks for this PR for all-green and all-red cases without issues.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Jan 17, 2024
@PawelWMS PawelWMS force-pushed the pawelwi/actions_explicit_permissions branch from 67af008 to 9ef949e Compare January 17, 2024 00:30
@PawelWMS PawelWMS changed the title Checking required GitHub Actions' permissions. Making GitHub Actions' permissions explicit. Jan 17, 2024
@PawelWMS PawelWMS marked this pull request as ready for review January 17, 2024 00:38
@PawelWMS PawelWMS requested a review from a team as a code owner January 17, 2024 00:38
@PawelWMS PawelWMS merged commit 52ea900 into microsoft:main Jan 17, 2024
@PawelWMS PawelWMS deleted the pawelwi/actions_explicit_permissions branch January 17, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants