Image Customizer: Make either one of split partitions format and output image format required#7323
Merged
amritakohli merged 3 commits intomicrosoft:mainfrom Jan 18, 2024
Merged
Conversation
romoh
approved these changes
Jan 18, 2024
cwize1
approved these changes
Jan 18, 2024
cwize1
pushed a commit
that referenced
this pull request
Jan 18, 2024
…ut image format required (#7323)
cwize1
pushed a commit
that referenced
this pull request
Jan 18, 2024
…ut image format required (#7323)
BettyRain
pushed a commit
that referenced
this pull request
Jan 23, 2024
…ut image format required (#7323)
BettyRain
pushed a commit
that referenced
this pull request
Jan 26, 2024
…ut image format required (#7323)
sharath-srikanth-chellappa
pushed a commit
that referenced
this pull request
Jan 26, 2024
…ut image format required (#7323)
sharath-srikanth-chellappa
pushed a commit
that referenced
this pull request
Jan 26, 2024
…ut image format required (#7323)
sharath-srikanth-chellappa
pushed a commit
that referenced
this pull request
Jan 26, 2024
…ut image format required (#7323)
BettyRain
pushed a commit
that referenced
this pull request
Jan 27, 2024
…ut image format required (#7323)
Adub17030MS
pushed a commit
that referenced
this pull request
Feb 9, 2024
…ut image format required (#7323)
Xiaohong-Deng
pushed a commit
to Xiaohong-Deng/azurelinux
that referenced
this pull request
Nov 23, 2024
…ut image format required (microsoft#7323)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
We want to allow user to extract just the partition files and not the image file itself. We also want the user to be able to extract the image and not partition files.
This change makes either one of the two flags,
--output-split-partitions-formatand--output-image-format, required to allow for this.Previously, output image format was a required argument.
Change Log
Does this affect the toolchain?
NO
Test Methodology
Error example:
sudo go run ./imagecustomizer --build-dir ./build --image-file ~/core-2.0.20231115.vhdx --output-image-file ./out/image5.raw --config-file ~/config-3.yaml
imagecustomizer: error: Either --output-image-format or --output-split-partitions-format must be specified.
exit status 1