Skip to content

Add epoch to libdwarf spec to fix versioning order#7337

Merged
jslobodzian merged 1 commit intofasttrack/2.0from
sindhu/fix_libdwarf_version
Jan 19, 2024
Merged

Add epoch to libdwarf spec to fix versioning order#7337
jslobodzian merged 1 commit intofasttrack/2.0from
sindhu/fix_libdwarf_version

Conversation

@sindhu-karri
Copy link
Copy Markdown
Contributor

@sindhu-karri sindhu-karri commented Jan 19, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
The PR adds an epoch version to the package.
The versioning of the package has changed from date versioning to normal versioning in the last upgrade.
version before upgrade: 20200114
version after upgrade: 0.9.0
Since the version after upgrade is numerically lower, package manager treats it as an older version and the CVEs on the earlier versions are being detected on the current version even though they're not applicable.

Change Log
  • Add Epoch to fix version ordering as date versioning had changed to normal versioning
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@sindhu-karri sindhu-karri marked this pull request as ready for review January 19, 2024 08:23
@sindhu-karri sindhu-karri requested a review from a team as a code owner January 19, 2024 08:23
@mfrw mfrw added the fasttrack/2.0 PRs Destined for Azure Linux 2.0 label Jan 19, 2024
Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

An idea I would like to bounce across, we have moved libdwarf recently to SPECS from SPECS-EXTENDED, how about, we remove the libdwarf rpms from the extended repo ? That way we need not add the Epoch tag.
/cc @jslobodzian @PawelWMS @anphel31

@sindhu-karri
Copy link
Copy Markdown
Contributor Author

LGTM :)

An idea I would like to bounce across, we have moved libdwarf recently to SPECS from SPECS-EXTENDED, how about, we remove the libdwarf rpms from the extended repo ? That way we need not add the Epoch tag. /cc @jslobodzian @PawelWMS @anphel31

Hi @mfrw, The package is published to core repos now, with the 20240117 release

@jslobodzian jslobodzian merged commit 374bd03 into fasttrack/2.0 Jan 19, 2024
@jslobodzian jslobodzian deleted the sindhu/fix_libdwarf_version branch January 19, 2024 15:11
CBL-Mariner-Bot pushed a commit that referenced this pull request Jan 19, 2024
@CBL-Mariner-Bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fasttrack/2.0 PRs Destined for Azure Linux 2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants