Skip to content

patch vendored go module quic-go for package coredns to address CVE-2023-49295#7502

Merged
mbykhovtsev-ms merged 9 commits intomainfrom
mbykhovtsev/patch-quic-go
Feb 6, 2024
Merged

patch vendored go module quic-go for package coredns to address CVE-2023-49295#7502
mbykhovtsev-ms merged 9 commits intomainfrom
mbykhovtsev/patch-quic-go

Conversation

@mbykhovtsev-ms
Copy link
Copy Markdown
Contributor

@mbykhovtsev-ms mbykhovtsev-ms commented Jan 26, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Added patch for a go module vendored dependency to address CVE-2023-49295

Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

@mbykhovtsev-ms mbykhovtsev-ms requested a review from a team as a code owner January 26, 2024 23:50
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Jan 26, 2024
@mfrw mfrw added the security label Jan 28, 2024
Comment thread SPECS/coredns/coredns.spec Outdated
Copy link
Copy Markdown
Contributor

@dmcilvaney dmcilvaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, going to be PR'ing a fix to fasttrack that will conflict with this. It will be bringing an updated vendor tar. This PR will just need release++, I think it should otherwise apply on top (although double check the patch still applies... my PR messes with the dependencies so the exact versions of packages might have changed).

@mbykhovtsev-ms
Copy link
Copy Markdown
Contributor Author

FYI, going to be PR'ing a fix to fasttrack that will conflict with this. It will be bringing an updated vendor tar. This PR will just need release++, I think it should otherwise apply on top (although double check the patch still applies... my PR messes with the dependencies so the exact versions of packages might have changed).

Sure, no problem. Keep me posted, once your changes are in I will sync my branch and re-build to verify everything is fine.

@dmcilvaney
Copy link
Copy Markdown
Contributor

#7524

@dmcilvaney
Copy link
Copy Markdown
Contributor

@mbykhovtsev-ms PR is in, feel free to get changes and update as needed.

@dmcilvaney dmcilvaney self-requested a review February 2, 2024 20:12
@mbykhovtsev-ms mbykhovtsev-ms merged commit 87dd34c into main Feb 6, 2024
@mbykhovtsev-ms mbykhovtsev-ms deleted the mbykhovtsev/patch-quic-go branch February 6, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants