Skip to content

patch CVE-2022-21698 in application-gateway-kubernetes-ingress#7542

Merged
tobiasb-ms merged 3 commits intofasttrack/2.0from
tobiasb/cve-2022-21698-application-gateway-kubernetes-ingress
Jan 30, 2024
Merged

patch CVE-2022-21698 in application-gateway-kubernetes-ingress#7542
tobiasb-ms merged 3 commits intofasttrack/2.0from
tobiasb/cve-2022-21698-application-gateway-kubernetes-ingress

Conversation

@tobiasb-ms
Copy link
Copy Markdown
Contributor

@tobiasb-ms tobiasb-ms commented Jan 30, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Fixes CVE-2022-21698 for application-gateway-kubernetes-ingress. The vulnerability is in the client_golang go module, which is vendored in this package. Fix is to apply a (modified) patch to the vendored code.

Change Log
  • Modified the upstream patch to work with the older version of client_golang used by this package, along with getting rid of tests.
  • Modified the spec file to do all the source-related munging in the prep stage.
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

@tobiasb-ms tobiasb-ms requested a review from a team as a code owner January 30, 2024 19:51
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one simple ask for the %patch macro but looks good.

@tobiasb-ms tobiasb-ms merged commit f0d5827 into fasttrack/2.0 Jan 30, 2024
@tobiasb-ms tobiasb-ms deleted the tobiasb/cve-2022-21698-application-gateway-kubernetes-ingress branch January 30, 2024 23:55
CBL-Mariner-Bot pushed a commit that referenced this pull request Jan 30, 2024
Fixes CVE-2022-21698 for application-gateway-kubernetes-ingress. The vulnerability is in the client_golang go module, which is vendored in this package. Fix is to apply a (modified) patch to the vendored code.

(cherry picked from commit f0d5827)
@CBL-Mariner-Bot
Copy link
Copy Markdown
Collaborator

tobiasb-ms added a commit that referenced this pull request Jan 31, 2024
…tes-ingress - branch main (#7548)

This is an auto-generated pull request to cherry-pick commit f0d5827 to main. Original PR: #7542
Co-authored-by: Tobias Brick <39196763+tobiasb-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants