Skip to content

Patch waagent.conf to add firewall rules#7543

Merged
liunan-ms merged 2 commits intomainfrom
liunan/waagent
Feb 16, 2024
Merged

Patch waagent.conf to add firewall rules#7543
liunan-ms merged 2 commits intomainfrom
liunan/waagent

Conversation

@liunan-ms
Copy link
Copy Markdown
Contributor

@liunan-ms liunan-ms commented Jan 30, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Add EnableFirewall flag to waagent.conf to protect access to Azure host node services.

Change Log
  • Patch waagent.conf to add firewall rules to protect access to Azure host node
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology

@liunan-ms liunan-ms requested a review from a team as a code owner January 30, 2024 22:15
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Jan 30, 2024
Comment thread SPECS/WALinuxAgent/WALinuxAgent.spec Outdated
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@christopherco christopherco requested a review from a team February 8, 2024 15:13
@eric-desrochers
Copy link
Copy Markdown
Contributor

@narrieta for visibility and reviewal from a WALA team perspective.

Copy link
Copy Markdown
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hbeberman
Copy link
Copy Markdown
Member

Can you verify that this works as intended on an AKS node?

Our AKS images leave management of iptables up to Kubernetes, so I want to make sure the rules this writes aren't interfering or getting overwritten.

@liunan-ms liunan-ms merged commit cd42b14 into main Feb 16, 2024
@liunan-ms liunan-ms deleted the liunan/waagent branch February 16, 2024 19:47
christopherco added a commit to christopherco/CBL-Mariner that referenced this pull request Feb 23, 2024
SeanDougherty pushed a commit that referenced this pull request Mar 1, 2024
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
christopherco added a commit to christopherco/CBL-Mariner that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants