Conversation
mfrw
reviewed
Jan 31, 2024
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Contributor
|
@narrieta for visibility and reviewal from a WALA team perspective. |
Member
|
Can you verify that this works as intended on an AKS node? Our AKS images leave management of iptables up to Kubernetes, so I want to make sure the rules this writes aren't interfering or getting overwritten. |
hbeberman
approved these changes
Feb 16, 2024
christopherco
added a commit
to christopherco/CBL-Mariner
that referenced
this pull request
Feb 23, 2024
This reverts commit cd42b14.
christopherco
added a commit
that referenced
this pull request
Feb 23, 2024
SeanDougherty
pushed a commit
that referenced
this pull request
Mar 1, 2024
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
SeanDougherty
pushed a commit
that referenced
this pull request
Mar 1, 2024
christopherco
added a commit
to christopherco/CBL-Mariner
that referenced
this pull request
Mar 11, 2024
)" (microsoft#8054)" This reverts commit eb62644.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Add EnableFirewall flag to waagent.conf to protect access to Azure host node services.
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology