Skip to content

Update sos to 4.6.1#7553

Merged
aadhar-agarwal merged 1 commit intomicrosoft:mainfrom
aadhar-agarwal:aadagarwal/update-sos
Feb 5, 2024
Merged

Update sos to 4.6.1#7553
aadhar-agarwal merged 1 commit intomicrosoft:mainfrom
aadhar-agarwal:aadagarwal/update-sos

Conversation

@aadhar-agarwal
Copy link
Copy Markdown
Contributor

@aadhar-agarwal aadhar-agarwal commented Jan 31, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

  • This PR upgrades the sos package to 4.6.1
  • This is the same change that was made for 3.0-dev (PR link)
Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Jan 31, 2024
@aadhar-agarwal aadhar-agarwal marked this pull request as ready for review January 31, 2024 17:14
@aadhar-agarwal aadhar-agarwal requested a review from a team as a code owner January 31, 2024 17:14
Copy link
Copy Markdown
Contributor

@ddstreetmicrosoft ddstreetmicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Copy Markdown
Contributor

@eric-desrochers eric-desrochers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would wait for Esteban (Escalation team) validation before merging.

@aadhar-agarwal aadhar-agarwal merged commit 9a4ea2e into microsoft:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants