Conversation
Signed-off-by: Roaa Sakr <romoh@microsoft.com>
vinceaperri
approved these changes
Feb 6, 2024
vinceaperri
reviewed
Feb 6, 2024
vinceaperri
previously approved these changes
Feb 6, 2024
neha170
reviewed
Feb 6, 2024
Contributor
|
The '/srv' -> '/var/srv' symlink is created by the |
cwize1
requested changes
Feb 6, 2024
Contributor
Author
It is created by both. |
cwize1
approved these changes
Feb 7, 2024
vinceaperri
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove /srv linking that is created by the toolchain & filesystems package. Toolkit and filesystem package unnecessarily symlink /var/srv & /srv which interferes with other scenarios. This will be fixed in Mariner 3.0, this PR is a mitigation for 2.0 images.
More details:
On any mariner image, the symlink is left behind which is interfering with scenarios where customers want to mount a volume over /srv
PR also adds cleanup for any logs that may be left after the build process is completed.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Does this affect the toolchain?
NO
Test Methodology
Built locally and validated.