Skip to content

fix cve-2022-21698 in node-problem-detector#7689

Merged
jslobodzian merged 1 commit intofasttrack/2.0from
tobiasb/cve-2022-21698-node-problem-detector
Feb 7, 2024
Merged

fix cve-2022-21698 in node-problem-detector#7689
jslobodzian merged 1 commit intofasttrack/2.0from
tobiasb/cve-2022-21698-node-problem-detector

Conversation

@tobiasb-ms
Copy link
Copy Markdown
Contributor

@tobiasb-ms tobiasb-ms commented Feb 5, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Fixes CVE-2022-21698 for node-problem-detector. The vulnerability is in the client_golang go module, which is vendored in this package. Fix is to apply a (modified) patch to the vendored code.

Change Log
  • Applied upstream patch to work with the older version of client_golang used by this package, along with getting rid of tests.
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

@tobiasb-ms tobiasb-ms requested a review from a team as a code owner February 5, 2024 22:29
@mfrw mfrw added the fasttrack/2.0 PRs Destined for Azure Linux 2.0 label Feb 6, 2024
@jslobodzian jslobodzian merged commit 0f52e8f into fasttrack/2.0 Feb 7, 2024
@jslobodzian jslobodzian deleted the tobiasb/cve-2022-21698-node-problem-detector branch February 7, 2024 01:03
@CBL-Mariner-Bot
Copy link
Copy Markdown
Collaborator

Auto cherry-pick results:

  • main ✅ -> Skipped

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=500532&view=results

tobiasb-ms added a commit that referenced this pull request Feb 8, 2024
…tector (#7689) (#7786)

Co-authored-by: jslobodzian <joslobo@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fasttrack/2.0 PRs Destined for Azure Linux 2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants