Skip to content

Removed extra double quote in the toolkit.#7736

Merged
PawelWMS merged 1 commit intomainfrom
pawelwi/double_quote_fix_2.0
Feb 7, 2024
Merged

Removed extra double quote in the toolkit.#7736
PawelWMS merged 1 commit intomainfrom
pawelwi/double_quote_fix_2.0

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS commented Feb 6, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Looks like we accidentally lest an extra double quote inside toolkit.mk. This is a small change fixing that.

Change Log
  • Removed the extra double quote in --log-color="$(LOG_COLOR)"".
Does this affect the toolchain?

No.

Test Methodology
  • Local test.

@PawelWMS PawelWMS requested a review from a team as a code owner February 6, 2024 23:54
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Feb 6, 2024
@PawelWMS PawelWMS merged commit 75a70a5 into main Feb 7, 2024
@PawelWMS PawelWMS deleted the pawelwi/double_quote_fix_2.0 branch February 7, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants